[Buildroot] [PATCHv3 16/18] Makefile: add BR_BUILDING variable

[Yann E. MORIN <yann.morin.1998@free.fr>]

Thomas, All,

On 2015-04-26 11:40 +0200, Thomas Petazzoni spake thusly:
> On Sat, 25 Apr 2015 23:14:57 +0200, Yann E. MORIN wrote:
> > I maintian my ack, but I have a deeper concern about not doing those
> > checks in the first place.
> > 
> > So, what does it mean not to have a config/board/... name to start with?
> > 
> > It means the specific configuration is not complete, and that the
> > package will fail to configure or build. So it does not make sense to
> > accept a configuration where such config name are missing.
> > 
> > Furthermore, what about a package that needs the config name to decide
> > what tarball to download? In that case, we can't do the check at all,
> > and we must fail as soon as the config name is empty.
> > 
> > As such, I'd prefer we do not condition the check on whether we'r
> > ebuilding or not, but that we do it always, fo all packages.
> > 
> > However, I can see one reason where we would still want the checks to be
> > conditional: make rand*config && make source-check . And that is a
> > tricky case to solve.
> > 
> > We could do it by always defining defaults (in the Config.in) to such
> > config names; those defaults could be conditional, of course. But coming
> > up with sane defaults is not easy either...
> > 
> > Thoughts?
> 
> I'd answer that this is a deeper discussion, into which I'd prefer to
> not get into at this point. The patch series is trying to keep the
> existing behavior, and I'd like to not change that for now.

Absolutely in agreement with that.

I never intended my comments to be taken as a suggestion to change your
series. I even stated that I did maintain my acked-by. ;-)

> Once this patch series gets merged, I'll be happy to rediscuss why we
> have this special casing on 'make source' / 'make source-check' to
> disable the checks.

Yup.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'