Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v6 02/15] gpu-viv-bin-mx6q: fix compiling issues with EGL_API_FB
Date: Thu, 30 Apr 2015 10:30:34 +0200	[thread overview]
Message-ID: <20150430103034.4d1032c7@free-electrons.com> (raw)
In-Reply-To: <1421451251-23366-3-git-send-email-jezz@sysmic.org>

Dear J?r?me Pouiller,

On Sat, 17 Jan 2015 00:33:58 +0100, J?r?me Pouiller wrote:

>  define GPU_VIV_BIN_MX6Q_INSTALL_STAGING_CMDS
>  	cp -r $(@D)/usr/* $(STAGING_DIR)/usr
> +	if [ $(GPU_VIV_BIN_MX6Q_LIB_TARGET) == fb ]; then \
> +		$(SED) '/#define EGLAPIENTRY/ a \
> +			#if !defined(EGL_API_X11) && !defined(EGL_API_DFB) && !defined(EGL_API_FB) \n\
> +			#define EGL_API_FB \n\
> +			#endif' $(STAGING_DIR)/usr/include/EGL/eglvivante.h; \
> +	fi

This should have used a make test instead of a shell test, i.e:

ifeq ($(GPU_VIV_BIN_MX6Q_LIB_TARGET),fb)
define GPU_VIV_BIN_MX6Q_FIXUP_FB_HEADERS
	$(SED) '/#define EGLAPIENTRY/ a \
		#if !defined(EGL_API_X11) && !defined(EGL_API_DFB) && !defined(EGL_API_FB) \n\
		#define EGL_API_FB \n\
		#endif' $(STAGING_DIR)/usr/include/EGL/eglvivante.h; \
endef
endif

define GPU_VIV_BIN_MX6Q_INSTALL_STAGING_CMDS
	cp -r $(@D)/usr/* $(STAGING_DIR)/usr
	$(GPU_VIV_BIN_MX6Q_FIXUP_FB_HEADERS)
endef

Can be fixed up when applying the patch.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  parent reply	other threads:[~2015-04-30  8:30 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-16 23:33 [Buildroot] [PATCH v6 00/15] Add Xorg support for iMX6 Jérôme Pouiller
2015-01-16 23:33 ` [Buildroot] [PATCH v6 01/15] mesa3d: Give possibility to external backends to enable DRI/Gallium Jérôme Pouiller
2015-01-17 17:02   ` Bernd Kuhls
2015-04-30  8:16   ` [Buildroot] [v6, " Gary Bisson
2015-04-30  8:26     ` Thomas Petazzoni
2015-01-16 23:33 ` [Buildroot] [PATCH v6 02/15] gpu-viv-bin-mx6q: fix compiling issues with EGL_API_FB Jérôme Pouiller
2015-04-30  8:21   ` [Buildroot] [v6, " Gary Bisson
2015-04-30  8:30   ` Thomas Petazzoni [this message]
2015-01-16 23:33 ` [Buildroot] [PATCH v6 03/15] gpu-viv-bin-mx6q: make fb/x11 choice explicit Jérôme Pouiller
2015-04-30  8:29   ` [Buildroot] [v6, " Gary Bisson
2015-04-30  8:31   ` [Buildroot] [PATCH v6 " Thomas Petazzoni
2015-01-16 23:34 ` [Buildroot] [PATCH v6 04/15] gpu-viv-bin-mx6q: remove useless build time deps Jérôme Pouiller
2015-04-30  8:32   ` [Buildroot] [v6, " Gary Bisson
2015-01-16 23:34 ` [Buildroot] [PATCH v6 05/15] gpu-viv-bin-mx6q: add version in libraries symlinks Jérôme Pouiller
2015-04-30  8:37   ` [Buildroot] [v6, " Gary Bisson
2015-01-16 23:34 ` [Buildroot] [PATCH v6 06/15] gpu-viv-bin-mx6q: change output selection mechanism Jérôme Pouiller
2015-04-30  8:40   ` [Buildroot] [v6, " Gary Bisson
2015-01-16 23:34 ` [Buildroot] [PATCH v6 07/15] xdriver_xf86-video-imx-viv: new package Jérôme Pouiller
2015-04-30  8:46   ` [Buildroot] [v6,07/15] " Gary Bisson
2015-01-16 23:34 ` [Buildroot] [PATCH v6 08/15] qt5base: apply new patch naming policy Jérôme Pouiller
2015-04-30  8:47   ` [Buildroot] [v6,08/15] " Gary Bisson
2015-01-16 23:34 ` [Buildroot] [PATCH v6 09/15] qt5base: fix compilation with Vivante headers Jérôme Pouiller
2015-04-30  8:52   ` [Buildroot] [v6, " Gary Bisson
2015-01-16 23:34 ` [Buildroot] [PATCH v6 10/15] qt5base: fix "Unable to find an X11 visual" error Jérôme Pouiller
2015-04-30  8:55   ` [Buildroot] [v6, " Gary Bisson
2015-01-16 23:34 ` [Buildroot] [PATCH v6 11/15] Vivante drivers: bump to version 3.10.17-1.0.1 Jérôme Pouiller
2015-04-30  8:57   ` [Buildroot] [v6, " Gary Bisson
2015-01-16 23:34 ` [Buildroot] [PATCH v6 12/15] nitrogen6x_defconfig: bump kernel to 3.10.17_1.0.1_ga Jérôme Pouiller
2015-04-30  8:58   ` [Buildroot] [v6, " Gary Bisson
2015-01-16 23:34 ` [Buildroot] [PATCH v6 13/15] freescale_imx6*_defconfig: " Jérôme Pouiller
2015-04-30  9:00   ` [Buildroot] [v6, " Gary Bisson
2015-01-16 23:34 ` [Buildroot] [PATCH v6 14/15] qmx6_defconfig: update Jérôme Pouiller
2015-04-30  9:02   ` [Buildroot] [v6,14/15] " Gary Bisson
2015-01-16 23:34 ` [Buildroot] [PATCH v6 15/15] qmx6_qt5_demo_defconfig: new defconfig Jérôme Pouiller
2015-04-30  9:03   ` [Buildroot] [v6,15/15] " Gary Bisson
2015-01-22  6:47 ` [Buildroot] [PATCH v6 00/15] Add Xorg support for iMX6 Gary Bisson
2015-04-09 16:03   ` Gary Bisson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150430103034.4d1032c7@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox