From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yann E. MORIN Date: Fri, 1 May 2015 17:38:41 +0200 Subject: [Buildroot] [PATCH 6/7] linux: do not check hashes for custom versions and tarballs In-Reply-To: <554380DB.40503@mind.be> References: <554380DB.40503@mind.be> Message-ID: <20150501153841.GD4206@free.fr> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Arnout, All, On 2015-05-01 15:34 +0200, Arnout Vandecappelle spake thusly: > Hah, this is a tough one... Doh, right... > With the combination BR2_LINUX_SAME_AS_HEADERS and BR2_KERNEL_HEADERS_VERSION > you can still get a custom version... Hmm.. I missed that case... :-/ > So I'm thinking if it wouldn't be simpler to just always disable the hash: > BR_NO_CHECK_HASH_FOR += $(LINUX_SOURCE) > > Note that the hash, if it exists, will still be checked; it just won't be an > error if the hash doesn't exist (so the variable is not named very accurately in > fact). Therefore I think it's safe to disable it completely for linux. Well, I stand on my position that I'd like we only exclude only what we strictly require to be excluded. > Or, if > you prefer you can make it depend on !BR2_LINUX_KERNEL_LATEST_VERSION && > !(BR2_LINUX_SAME_AS_HEADERS && !BR2_KERNEL_HEADERS_VERSION) (good luck > expressing that in make syntax :-). Well, we still have the option of expressing that in Kconfig if that can help... > On 29/04/15 00:40, Yann E. MORIN wrote: > > Signed-off-by: "Yann E. MORIN" > > Cc: Thomas Petazzoni > > --- > > linux/linux.mk | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/linux/linux.mk b/linux/linux.mk > > index 0c348da..959c564 100644 > > --- a/linux/linux.mk > > +++ b/linux/linux.mk > > @@ -13,8 +13,10 @@ ifeq ($(BR2_LINUX_KERNEL_CUSTOM_TARBALL),y) > > LINUX_TARBALL = $(call qstrip,$(BR2_LINUX_KERNEL_CUSTOM_TARBALL_LOCATION)) > > LINUX_SITE = $(patsubst %/,%,$(dir $(LINUX_TARBALL))) > > LINUX_SOURCE = $(notdir $(LINUX_TARBALL)) > > +BR_NO_CHECK_HASH_FOR += $(LINUX_SOURCE) > > else ifeq ($(BR2_LINUX_KERNEL_CUSTOM_LOCAL),y) > > LINUX_SITE = $(call qstrip,$(BR2_LINUX_KERNEL_CUSTOM_LOCAL_PATH)) > > +# For 'local', there is no hash check, so no need to set BR_NO_CHECK_HASH_FOR > > Why do you add that comment here and not in the VCS cases? I don't think it is > needed, move it to the commit message. OK. Regards, Yann E. MORIN. -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'