From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/3] package/wvstreams: add argp-standalone as optionnal dependency
Date: Fri, 1 May 2015 23:04:02 +0200 [thread overview]
Message-ID: <20150501230402.57253929@free-electrons.com> (raw)
In-Reply-To: <1430498686-10719-3-git-send-email-romain.naour@openwide.fr>
Dear Romain Naour,
On Fri, 1 May 2015 18:44:46 +0200, Romain Naour wrote:
> This ensures the build reproducibility.
>
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
> ---
> package/wvstreams/wvstreams.mk | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/package/wvstreams/wvstreams.mk b/package/wvstreams/wvstreams.mk
> index bc7c5d4..3db317a 100644
> --- a/package/wvstreams/wvstreams.mk
> +++ b/package/wvstreams/wvstreams.mk
> @@ -32,6 +32,11 @@ ifneq ($(BR2_STATIC_LIBS),y)
> WVSTREAMS_CONF_ENV += CFLAGS="$(TARGET_CFLAGS) -fPIC"
> endif
>
> +# wvstreams use argp.h which can be provided by argp-standalone package.
> +ifeq ($(BR2_PACKAGE_ARGP_STANDALONE),y)
> +WVSTREAMS_DEPENDENCIES += argp-standalone
> +endif
Applied after fixing typos in the commit title and comment.
I wonder if we shouldn't make the argp-standalone package only
available on !glibc builds, since glibc provides its own argp
implementation.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-05-01 21:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-01 16:44 [Buildroot] [PATCH 1/3] package/argp-standalone: format patches to git patches Romain Naour
2015-05-01 16:44 ` [Buildroot] [PATCH 2/3] package/argp-standalone: add missing limits.h Romain Naour
2015-05-01 17:29 ` Max Filippov
2015-05-01 20:48 ` Thomas Petazzoni
2015-05-01 21:40 ` Romain Naour
2015-05-01 16:44 ` [Buildroot] [PATCH 3/3] package/wvstreams: add argp-standalone as optionnal dependency Romain Naour
2015-05-01 21:04 ` Thomas Petazzoni [this message]
2015-05-01 22:21 ` Romain Naour
2015-05-02 6:57 ` Peter Korsgaard
2015-05-02 8:30 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150501230402.57253929@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox