From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/tinyxml2: Use BUILD_SHARED_LIBS cmake standard
Date: Mon, 11 May 2015 11:30:02 +0200 [thread overview]
Message-ID: <20150511113002.12e1cc72@free-electrons.com> (raw)
In-Reply-To: <554D1AB6.5020401@openwide.fr>
Dear Romain Naour,
On Fri, 08 May 2015 22:21:10 +0200, Romain Naour wrote:
> >> + ################################
> >> +@@ -46,12 +46,8 @@ endif(MSVC)
> >> +
> >> + ################################
> >> + # Add targets
> >> +-set(BUILD_STATIC_LIBS ON CACHE BOOL "Set to ON to build static libraries")
> >> +-if(BUILD_STATIC_LIBS)
> >> +- add_library(tinyxml2static STATIC tinyxml2.cpp tinyxml2.h)
> >> +- set_target_properties(tinyxml2static PROPERTIES OUTPUT_NAME tinyxml2)
> >> +-endif(BUILD_STATIC_LIBS)
> >> +-add_library(tinyxml2 SHARED tinyxml2.cpp tinyxml2.h)
> >> ++option(BUILD_SHARED_LIBS "build shared or static libraries" ON)
> > Not needed, this is a global CMake flag.
>
> I have just cherry-picked the patch and keep things as is.
> I can rework the patch an keep only useful part if you prefer ;-)
No, if it is an upstream patch, please keep it as unmodified as
possible when backporting it to Buildroot.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-05-11 9:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-08 10:42 [Buildroot] [PATCH] package/tinyxml2: Use BUILD_SHARED_LIBS cmake standard Romain Naour
2015-05-08 10:43 ` [Buildroot] [PATCH] package/tinyxml2: fix cmake warning Romain Naour
2015-05-08 19:53 ` [Buildroot] [PATCH] package/tinyxml2: Use BUILD_SHARED_LIBS cmake standard Samuel Martin
2015-05-08 20:21 ` Romain Naour
2015-05-11 9:30 ` Thomas Petazzoni [this message]
2015-05-11 20:36 ` Romain Naour
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150511113002.12e1cc72@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox