From mboxrd@z Thu Jan 1 00:00:00 1970 From: Baruch Siach Date: Wed, 13 May 2015 06:16:17 +0300 Subject: [Buildroot] [PATCH v2 2/2] powerpc-utils: optionally use librtas In-Reply-To: <4a40d63bb8a0fdf9a3dc8811a62dc7872fcddd87.1431403924.git.sam.bobroff@au1.ibm.com> References: <4a40d63bb8a0fdf9a3dc8811a62dc7872fcddd87.1431403924.git.sam.bobroff@au1.ibm.com> Message-ID: <20150513031617.GD2558@tarshish> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hi Sam, On Tue, May 12, 2015 at 02:12:08PM +1000, Sam Bobroff wrote: > diff --git a/package/powerpc-utils/powerpc-utils.mk b/package/powerpc-utils/powerpc-utils.mk > index 3b30458..486ed20 100644 > --- a/package/powerpc-utils/powerpc-utils.mk > +++ b/package/powerpc-utils/powerpc-utils.mk > @@ -7,10 +7,15 @@ > POWERPC_UTILS_VERSION = 1.2.24 > POWERPC_UTILS_SITE = http://downloads.sourceforge.net/project/powerpc-utils/powerpc-utils > POWERPC_UTILS_DEPENDENCIES = zlib > +ifeq ($(BR2_PACKAGE_POWERPC_UTILS_RTAS),y) > +POWERPC_UTILS_DEPENDENCIES += librtas > +endif > POWERPC_UTILS_LICENSE = Common Public License Version 1.0 > POWERPC_UTILS_LICENSE_FILES = COPYRIGHT > > +ifeq ($(BR2_PACKAGE_POWERPC_UTILS_RTAS),) > POWERPC_UTILS_CONF_OPTS = --without-librtas > +endif The usual convention is to put dependency handling in one place, and to have both "with" and "without". ifeq ($(BR2_PACKAGE_POWERPC_UTILS_RTAS),y) POWERPC_UTILS_DEPENDENCIES += librtas POWERPC_UTILS_CONF_OPTS = --with-librtas else POWERPC_UTILS_CONF_OPTS = --without-librtas endif baruch -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -