From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 5/6] nommu/flat: don't add -elf2flt for some toolchains
Date: Mon, 18 May 2015 21:58:41 +0200 [thread overview]
Message-ID: <20150518215841.2926908a@free-electrons.com> (raw)
In-Reply-To: <1431959088-15257-6-git-send-email-guido@vanguardiasur.com.ar>
Dear Guido Mart?nez,
On Mon, 18 May 2015 11:24:47 -0300, Guido Mart?nez wrote:
> ifeq ($(BR2_BINFMT_FLAT),y)
> +# Don't add any flags for toolchains that don't require it
> +ifneq ($(BR2_TOOLCHAIN_DONT_ELF2FLT),y)
An option named "DONT_<something>" really isn't nice.
> TARGET_CFLAGS += $(if $($(PKG)_FLAT_STACKSIZE),-Wl$(comma)-elf2flt=-s$($(PKG)_FLAT_STACKSIZE),\
> -Wl$(comma)-elf2flt)
> TARGET_CXXFLAGS += $(if $($(PKG)_FLAT_STACKSIZE),-Wl$(comma)-elf2flt=-s$($(PKG)_FLAT_STACKSIZE),\
> -Wl$(comma)-elf2flt)
> TARGET_LDFLAGS += $(if $($(PKG)_FLAT_STACKSIZE),-elf2flt=-s$($(PKG)_FLAT_STACKSIZE),-elf2flt)
But the Blackfin toolchain also doesn't need -elf2flt as far as I know,
the FLAT toolchain also directly produces FLAT binaries without
specifying any flags. Maybe we should instead adjust the logic here
instead of working around it?
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-05-18 19:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-18 14:24 [Buildroot] [PATCH v2 0/6] Add ARM Cortex-M3 support Guido Martínez
2015-05-18 14:24 ` [Buildroot] [PATCH v2 1/6] arm: update processor types Guido Martínez
2015-05-18 20:05 ` Thomas Petazzoni
2015-05-19 15:53 ` Guido Martínez
2015-05-21 16:51 ` Guido Martínez
2015-05-18 14:24 ` [Buildroot] [PATCH v2 2/6] pkg-utils: implement INFLATE for .deb files Guido Martínez
2015-05-18 19:55 ` Thomas Petazzoni
2015-05-19 16:00 ` Guido Martínez
2015-05-18 14:24 ` [Buildroot] [PATCH v2 3/6] toolchain: allow for stupid toolchains Guido Martínez
2015-05-18 14:24 ` [Buildroot] [PATCH v2 4/6] toolchain: introduce BR2_TOOLCHAIN_HAS_RESOLVER Guido Martínez
2015-05-18 14:24 ` [Buildroot] [PATCH v2 5/6] nommu/flat: don't add -elf2flt for some toolchains Guido Martínez
2015-05-18 19:58 ` Thomas Petazzoni [this message]
2015-05-19 19:00 ` Guido Martínez
2015-05-18 14:24 ` [Buildroot] [PATCH v2 6/6] toolchain-external: add OSELAS 2014.12.0 Cortex-M3 toolchain Guido Martínez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150518215841.2926908a@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox