Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] busybox: add option to install ntp startup script
Date: Tue, 19 May 2015 08:00:27 +0300	[thread overview]
Message-ID: <20150519050027.GR2845@tarshish> (raw)
In-Reply-To: <CAJ3iQcqvv7mDnGiEzfGUCqXmTAkKmsKWiSH0cQU0PJ_c=rU75w@mail.gmail.com>

Hi Greg,

On Tue, May 19, 2015 at 12:23:21PM +0800, Gergely Imreh wrote:
> >> diff --git a/package/busybox/ntp.conf b/package/busybox/ntp.conf
> >> new file mode 100644
> >> index 0000000..9851d9f
> >> --- /dev/null
> >> +++ b/package/busybox/ntp.conf
> >> @@ -0,0 +1,2 @@
> >> +server 0.pool.ntp.org
> >> +server 1.pool.ntp.org
> >
> > Isn't 2 servers too few in general? If there's a default conf, maybe
> > use the same setup as the NTP Pool project page's simple setup at
> > http://www.pool.ntp.org/en/use.html
> >
> > --- /dev/null
> > +++ b/package/busybox/ntp.conf
> > @@ -0,0 +1,6 @@
> > +driftfile /var/lib/ntp/ntp.drift
> > +
> > +server 0.pool.ntp.org
> > +server 1.pool.ntp.org
> > +server 2.pool.ntp.org
> > +server 3.pool.ntp.org
> 
> Also, after trying a test build, the ntp.conf script from this patch
> is overwritten by package/ntp/ntpd.etc.conf anyways, so would not
> actually show up on the target (I'm assuming that the ntp package is
> selected).

That's the intended behaviour. Whenever you select a package that implements 
the same functionality as a Busybox applet, the selected package takes 
precedence. For this reason any such package should list busybox in its 
<PKG>_DEPENDENCIES. I see that the ntp package doesn't do so, but I think it's 
a bug. I'll send a patch shortly.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

  reply	other threads:[~2015-05-19  5:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-18 19:58 [Buildroot] [PATCH] busybox: add option to install ntp startup script Floris Bos
2015-05-19  3:08 ` Gergely Imreh
2015-05-19  4:23   ` Gergely Imreh
2015-05-19  5:00     ` Baruch Siach [this message]
2015-05-19  8:24   ` Floris Bos
2015-05-20  2:48     ` Gergely Imreh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150519050027.GR2845@tarshish \
    --to=baruch@tkos.co.il \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox