From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yann E. MORIN <yann.morin.1998@free.fr>
Date: Sat, 23 May 2015 11:23:19 +0200
Subject: [Buildroot] [PATCH 1/1] scripts/mkusers: allow users with no
 password value set
In-Reply-To: <1432308977-1284-1-git-send-email-james.knight@rockwellcollins.com>
References: <1432308977-1284-1-git-send-email-james.knight@rockwellcollins.com>
Message-ID: <20150523092319.GC3708@free.fr>
List-Id: <buildroot.busybox.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: buildroot@busybox.net

James, All,

On 2015-05-22 11:36 -0400, James Knight spake thusly:
> The following allows a user definition to specify that a created user
> entry should not have a password value set. Original implementation
> allowed a user definition to provide a password value of "-" (no quotes)
> to generate a crypt-encoded empty string value. In some cases, it may be
> desired to have no value specified for a user's password. By using a
> value "-" for a password, no value will be set in the shadow value.

Well, that commit log was not completely explicit about what the goal
was. What about something like:

    Currently, it is not possible to create a password-less user, i.e. a
    user that can log without providing a password. All we can do is
    create a user with an empty password, but a pasword nonetheless.

    Accept '-' as the password field, meaning that no password is set,
    which allows a user to log in by just providing is login, and no
    password will even be asked.

If you have yet a better explanation, go for it! ;-)

> Signed-off-by: James Knight <james.knight@rockwellcollins.com>

With the commit log more explicit, you can add:

Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Thanks! :-)

Regards,
Yann E. MORIN.

> ---
>  docs/manual/makeusers-syntax.txt | 3 ++-
>  support/scripts/mkusers          | 3 +++
>  2 files changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/docs/manual/makeusers-syntax.txt b/docs/manual/makeusers-syntax.txt
> index ffdb961..467e596 100644
> --- a/docs/manual/makeusers-syntax.txt
> +++ b/docs/manual/makeusers-syntax.txt
> @@ -31,7 +31,8 @@ Where:
>    then login is disabled. If prefixed with +=+, then it is interpreted
>    as clear-text, and will be crypt-encoded (using MD5). If prefixed with
>    +!=+, then the password will be crypt-encoded (using MD5) and login
> -  will be disabled. If set to +*+, then login is not allowed.
> +  will be disabled. If set to +*+, then login is not allowed. If set to 
> +  +-+, then no password value will be set.
>  - +home+ is the desired home directory for the user. If set to '-', no
>    home directory will be created, and the user's home will be +/+.
>    Explicitly setting +home+ to +/+ is not allowed.
> diff --git a/support/scripts/mkusers b/support/scripts/mkusers
> index 026519e..9c5c4dc 100755
> --- a/support/scripts/mkusers
> +++ b/support/scripts/mkusers
> @@ -318,6 +318,9 @@ add_one_user() {
>          *)  fail "home must be an absolute path\n";;
>      esac
>      case "${passwd}" in
> +        -)
> +            _passwd=""
> +            ;;
>          !=*)
>              _passwd='!'"$( encode_password "${passwd#!=}" )"
>              ;;
> -- 
> 1.9.5.msysgit.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'