Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/sconeserver: fix static link with openssl
Date: Sun, 31 May 2015 10:55:49 +0200	[thread overview]
Message-ID: <20150531085549.GA3658@free.fr> (raw)
In-Reply-To: <20150531103804.3f9f22a6@free-electrons.com>

Thomas, All,

On 2015-05-31 10:38 +0200, Thomas Petazzoni spake thusly:
> On Sat, 30 May 2015 16:19:11 +0200, Yann E. MORIN wrote:
> > When linking statically, the order of libraries on the linker command
> > line is important, and sconeserver got it wrong.
> > 
> > Also, isconeserver does not use pkg-config, so it misses the private
> 
>         ^^ typo
> 
> > libs of -lcrypto, which is linking with -lz.
> > 
> > Fix that:
> >   - add a patch to configure.in to fix the order of libraries;
> >   - forcibly pass -lz when lkinking statically with openssl.
> 
>                              ^^^ typo
> 
> Applied with those two typos fixed. 

Thanks! :-)

>It's really a pity that pkg-config
> isn't more widely used :-/ If openssl grows another dependency, we
> would have to fix this again...

For 2015.05, I only 'fixed' sconeserver with the patch you applied, but
for upstream, I submitted a more involved patch that makes use of
pkg-config, which upstream seems to be happy with so far (but have not
yet merged):
    https://github.com/sconemad/sconeserver/pull/1

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

      reply	other threads:[~2015-05-31  8:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-30 14:19 [Buildroot] [PATCH] package/sconeserver: fix static link with openssl Yann E. MORIN
2015-05-31  8:38 ` Thomas Petazzoni
2015-05-31  8:55   ` Yann E. MORIN [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150531085549.GA3658@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox