Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [V2] moarvm: new package
Date: Fri, 5 Jun 2015 07:50:07 +0200	[thread overview]
Message-ID: <20150605075007.410bd306@free-electrons.com> (raw)
In-Reply-To: <1433448072-13632-1-git-send-email-francois.perrad@gadz.org>

Dear Francois Perrad,

On Thu,  4 Jun 2015 22:01:12 +0200, Francois Perrad wrote:

> diff --git a/package/moarvm/Config.in b/package/moarvm/Config.in
> new file mode 100644
> index 0000000..4427e55
> --- /dev/null
> +++ b/package/moarvm/Config.in
> @@ -0,0 +1,14 @@
> +config BR2_PACKAGE_MOARVM
> +	bool "moarvm"
> +	depends on BR2_TOOLCHAIN_HAS_THREADS
> +	depends on BR2_PACKAGE_LIBATOMIC_ARCH_SUPPORTS

You don't use libatomic, so: why?

> +	help
> +	  MoarVM (short for Metamodel On A Runtime Virtual Machine) is
> +	  a runtime built for the 6model object system. It is primarily aimed
> +	  at running NQP and Rakudo Perl 6, but should be able to serve as
> +	  a backend for any compilers built using the NQP compiler toolchain.

I think the lines of the help text are slightly too long.

> +MOARVM_CONF_OPTS = \
> +	--build=$(GNU_HOST_NAME) \
> +	--host=$(GNU_TARGET_NAME) \
> +	--ar="$(TARGET_AR)" \
> +	--cc="$(TARGET_CC)" \
> +	--ld="$(TARGET_CC)" \
> +	--prefix="/usr"
> +
> +ifeq ($(BR2_ENDIAN),"BIG")
> +MOARVM_CONF_OPTS += --big-endian
> +endif
> +
> +define MOARVM_CONFIGURE_CMDS
> +	(cd $(@D); perl Configure.pl $(MOARVM_CONF_OPTS))

Is using the system provided Perl OK or should we use host-perl instead?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2015-06-05  5:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-04 20:01 [Buildroot] [V2] moarvm: new package Francois Perrad
2015-06-05  5:50 ` Thomas Petazzoni [this message]
2015-06-05  7:21   ` François Perrad
2015-06-05 13:36     ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150605075007.410bd306@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox