From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 02/12] fs/iso9660: convert to the filesystem infrastructure
Date: Sat, 6 Jun 2015 02:42:03 +0200 [thread overview]
Message-ID: <20150606024203.6651cc1a@free-electrons.com> (raw)
In-Reply-To: <20150605205841.GB3641@free.fr>
Dear Yann E. MORIN,
On Fri, 5 Jun 2015 22:58:41 +0200, Yann E. MORIN wrote:
> > ifeq ($(BR2_TARGET_GRUB_SPLASH),)
>
> I know this was pre-existing code, but we usually prefer positive logic.
> Do you think you might arrange to fix the logic in this test with
> anotehr patch? ;-)
Isn't that already positive logic?
"if BR2_TARGET_GRUB_SPLASH is disabled"
The other solution is:
ifneq ($(BR2_TARGET_GRUB_SPLASH),y)
which is "if not BR2_TARGET_GRUB_SPLASH is enabled"
which looks worse.
Am I missing something?
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-06-06 0:42 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-04 15:05 [Buildroot] [PATCH 00/12] iso9660 support improvements Thomas Petazzoni
2015-06-04 15:05 ` [Buildroot] [PATCH 01/12] fs/common: add <fs>_POST_GEN_HOOKS support Thomas Petazzoni
2015-06-05 9:43 ` Samuel Martin
2015-06-05 20:49 ` Yann E. MORIN
2015-06-04 15:05 ` [Buildroot] [PATCH 02/12] fs/iso9660: convert to the filesystem infrastructure Thomas Petazzoni
2015-06-05 11:59 ` Samuel Martin
2015-06-05 13:34 ` Thomas Petazzoni
2015-06-05 20:58 ` Yann E. MORIN
2015-06-06 0:42 ` Thomas Petazzoni [this message]
2015-06-06 9:01 ` Yann E. MORIN
2015-06-06 14:57 ` Thomas Petazzoni
2015-06-06 16:03 ` Yann E. MORIN
2015-06-05 22:44 ` Arnout Vandecappelle
2015-06-06 0:43 ` Thomas Petazzoni
2015-06-07 19:53 ` Yann E. MORIN
2015-06-04 15:05 ` [Buildroot] [PATCH 03/12] fs/iso9660: use if ... endif block instead of depends on Thomas Petazzoni
2015-06-05 12:01 ` Samuel Martin
2015-06-05 21:00 ` Yann E. MORIN
2015-06-04 15:05 ` [Buildroot] [PATCH 04/12] fs/iso9660: enable Joliet extension Thomas Petazzoni
2015-06-05 12:06 ` Samuel Martin
2015-06-05 21:18 ` Yann E. MORIN
2015-06-06 0:46 ` Thomas Petazzoni
2015-06-06 9:02 ` Yann E. MORIN
2015-06-04 15:05 ` [Buildroot] [PATCH 05/12] fs/iso9660: rename all variables to use the ROOTFS_ISO9660 prefix Thomas Petazzoni
2015-06-05 12:08 ` Samuel Martin
2015-06-05 21:20 ` Yann E. MORIN
2015-06-04 15:05 ` [Buildroot] [PATCH 06/12] fs/iso9660: change the location of the splash image Thomas Petazzoni
2015-06-05 12:09 ` Samuel Martin
2015-06-05 21:30 ` Yann E. MORIN
2015-06-04 15:05 ` [Buildroot] [PATCH 07/12] fs/iso9660: prepare cleaner kernel/initrd path handling Thomas Petazzoni
2015-06-05 12:11 ` Samuel Martin
2015-06-05 21:43 ` Yann E. MORIN
2015-06-05 22:06 ` Yann E. MORIN
2015-06-04 15:05 ` [Buildroot] [PATCH 08/12] fs/iso9660: support building a real iso9660 filesystem Thomas Petazzoni
2015-06-05 12:57 ` Samuel Martin
2015-06-05 22:13 ` Yann E. MORIN
2015-06-04 15:05 ` [Buildroot] [PATCH 09/12] fs/iso9660: add support for isolinux Thomas Petazzoni
2015-06-05 13:02 ` Samuel Martin
2015-06-05 22:38 ` Yann E. MORIN
2015-06-06 1:03 ` Thomas Petazzoni
2015-06-06 9:25 ` Yann E. MORIN
2015-06-04 15:05 ` [Buildroot] [PATCH 10/12] fs/iso9660: add hybrid image support Thomas Petazzoni
2015-06-05 13:07 ` Samuel Martin
2015-06-05 22:51 ` Yann E. MORIN
2015-06-04 15:05 ` [Buildroot] [PATCH 11/12] grub2: prepare and install El Torito image Thomas Petazzoni
2015-06-05 13:21 ` Samuel Martin
2015-06-05 22:55 ` Yann E. MORIN
2015-06-05 23:09 ` Yann E. MORIN
2015-06-06 0:57 ` Thomas Petazzoni
2015-06-06 9:31 ` Yann E. MORIN
2015-06-04 15:05 ` [Buildroot] [PATCH 12/12] fs/iso9660: add support for grub2 Thomas Petazzoni
2015-06-05 13:30 ` Samuel Martin
2015-06-05 23:07 ` Yann E. MORIN
2015-06-06 0:59 ` Thomas Petazzoni
2015-06-06 9:18 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150606024203.6651cc1a@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox