From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4] moarvm: new package
Date: Sat, 6 Jun 2015 17:05:08 +0200 [thread overview]
Message-ID: <20150606170508.76f27879@free-electrons.com> (raw)
In-Reply-To: <CAB0FRsu3Fh42P6d1sv6zk8YDRV7DCa-OSKn4P1dS7vgEP10j2w@mail.gmail.com>
Dear Fran?ois Perrad,
On Sat, 6 Jun 2015 11:03:38 +0200, Fran?ois Perrad wrote:
> > +MOARVM_DEPENDENCIES = host-luajit libuv libatomic_ops
>
> host-luajit seems overkill.
Why? Lua is not part of the core dependencies of Buildroot, which are
mandatory to run Buildroot. So if it's not part of these core
dependencies, and used for the build process of moarvm, then it should
be added as a dependency of that package.
Otherwise the build will fail for users that don't have Luajit
installed on their machine, like is the case for several of the
autobuilders.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-06-06 15:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-05 15:02 [Buildroot] [V3] moarvm: new package Francois Perrad
2015-06-05 22:26 ` Arnout Vandecappelle
2015-06-05 22:33 ` [Buildroot] [PATCH v4] " Arnout Vandecappelle
2015-06-05 23:47 ` [Buildroot] [PATCH v5] " Arnout Vandecappelle
2015-06-09 21:56 ` Thomas Petazzoni
2015-06-06 9:03 ` [Buildroot] [PATCH v4] " François Perrad
2015-06-06 15:05 ` Thomas Petazzoni [this message]
2015-06-06 16:17 ` François Perrad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150606170508.76f27879@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox