From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yann E. MORIN Date: Tue, 9 Jun 2015 23:51:04 +0200 Subject: [Buildroot] [PATCH 16/32 v2] package/matchbox-common: fix dependencies In-Reply-To: <20150609230440.6a91bd70@free-electrons.com> References: <9fa81fd7cbd6c1694dd4718ccf1ec24fe45f63fe.1433362840.git.yann.morin.1998@free.fr> <20150609230440.6a91bd70@free-electrons.com> Message-ID: <20150609215104.GA3671@free.fr> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Thomas, All, On 2015-06-09 23:04 +0200, Thomas Petazzoni spake thusly: > On Wed, 3 Jun 2015 22:41:33 +0200, Yann E. MORIN wrote: > > matchbox-common can be used by both matchbox-desktop and matchbox-panel, > > so it needs to depend on either, not both. > > > > Signed-off-by: "Yann E. MORIN" > > Reviewed-by: Arnout Vandecappelle (Essensium/Mind) > > --- > > package/matchbox-common/Config.in | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/package/matchbox-common/Config.in b/package/matchbox-common/Config.in > > index 33d6cc4..5a038e1 100644 > > --- a/package/matchbox-common/Config.in > > +++ b/package/matchbox-common/Config.in > > @@ -1,7 +1,7 @@ > > config BR2_PACKAGE_MATCHBOX_COMMON > > bool "matchbox-common" > > select BR2_PACKAGE_MATCHBOX_LIB > > - depends on BR2_PACKAGE_MATCHBOX_PANEL && BR2_PACKAGE_MATCHBOX_DESKTOP > > + depends on BR2_PACKAGE_MATCHBOX_PANEL || BR2_PACKAGE_MATCHBOX_DESKTOP > > help > > Common desktop folders and matchbox-session script. > > > > I'll apply because I want to apply the rest of the series, but why are > we doing this in the first place? I don't think packages in Buildroot > have a "depends on" on things that can *use* them. The dependencies in > Buildroot are always the other way around: you use a 'depends on' or a > 'select' because you need some other thing. > > Why isn't matchbox-common maybe always visible, like we do for all > packages ? As far as I understand it, matchbox-common installs the "desktop folders" which are only meaningful with a "desktop manager", i.e. either matchbox-panel or matchbox-desktop. Conversely, neither "matchbox-panel" nor "matchbox-desktop" require "matchbox-common". So I still believe the dependency is correct: - no reason to expose matchbox-common if neither matchbox-panel nor matchbox-desktop is available, - expose matchbox-common when either or both are enabled, - no reason to forcibly select matchbox-common from either of those two packages. Of course, someone actually using matchbox may well prove me wrong. ;-) Until then, that's all I can explain of what I understand of the matchbox stack. [ Unrelated to that patch, but worth commenting on, however: Besides, matchbox-panel and matchbox-desktop are not mutually exclusive at build time; at runtime, they can't both run simultaneously on the same X display, probably (it would be like running both Kwin and Unity at the same time on the same X display). ] Regards, Yann E. MORIN. -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'