From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Fri, 12 Jun 2015 23:39:36 +0200 Subject: [Buildroot] [PATCH 4/4] core/pkg-kconfig: allow saving config to a non-existing custom config file In-Reply-To: References: Message-ID: <20150612233936.40177f8c@free-electrons.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Dear Yann E. MORIN, On Sat, 6 Jun 2015 13:54:26 +0200, Yann E. MORIN wrote: > diff --git a/package/pkg-kconfig.mk b/package/pkg-kconfig.mk > index 6bb2559..453a59d 100644 > --- a/package/pkg-kconfig.mk > +++ b/package/pkg-kconfig.mk > @@ -90,9 +90,10 @@ endif > > # Configuration editors (menuconfig, ...) > # > -# Apply the kconfig fixups right after exiting the configurators, so > -# that the user always sees a .config file that is clean wrt. our > -# requirements. > +# We need to apply the configuration fixups right after a configuration > +# editor exits, so that it is possible to save the configuration right > +# after exiting an editor, and so the user always sees a .config file > +# that is clean wrt. our requirements. Shouldn't this chunk be part of the previous patch? > # > # Because commands in $(1)_FIXUP_KCONFIG are probably using $(@D), we > # fake it for the configurators (otherwise it is set to just '.', i.e. > @@ -108,14 +109,35 @@ $$(addprefix $(1)-,$$($(2)_KCONFIG_EDITORS)): $$($(2)_DIR)/.stamp_kconfig_fixup_ > rm -f $$($(2)_DIR)/.stamp_{target,staging,images}_installed > $$(call $(1)_FIXUP_KCONFIG) > > -$(1)-savedefconfig: $$($(2)_DIR)/.stamp_kconfig_fixup_done > +# Saving back the configuration > +# > +# Ideally, that should directly depend on $$($(2)_DIR)/.stamp_kconfig_fixup_done, > +# but that breaks the use-case in PR-8156 (from a clean tree): > +# make menuconfig <- enable kernel, use an in-tree defconfig, save and exit > +# make linux-menuconfig <- enable/disable whatever option, save and exit > +# make menuconfig <- change to use a custom defconfig file, set a path, save and exit > +# make linux-update-config <- should save to the new custom defconfig file > +# > +# Because of that use-case, saving the configuration can not directly depend can not -> cannot Other than that, looks good to me. Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com