From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] package/ffmpeg: Fix x86 compilation with gcc5
Date: Sun, 14 Jun 2015 22:56:20 +0200 [thread overview]
Message-ID: <20150614225620.02eafcbc@free-electrons.com> (raw)
In-Reply-To: <1434301872-30351-1-git-send-email-bernd.kuhls@t-online.de>
Dear Bernd Kuhls,
On Sun, 14 Jun 2015 19:11:11 +0200, Bernd Kuhls wrote:
> diff --git a/package/ffmpeg/ffmpeg.mk b/package/ffmpeg/ffmpeg.mk
> index 41ac616..479625c 100644
> --- a/package/ffmpeg/ffmpeg.mk
> +++ b/package/ffmpeg/ffmpeg.mk
> @@ -261,6 +261,7 @@ ifeq ($(BR2_X86_CPU_HAS_MMX),y)
> FFMPEG_CONF_OPTS += --enable-yasm
> FFMPEG_DEPENDENCIES += host-yasm
> else
> +FFMPEG_CONF_OPTS += --disable-asm
This will actually disable *all* ASM based optimizations, in all cases
(except on x86 with MMX). So it will potentially cause some severe
performance degradation, even if you're not using gcc 5.1. Shouldn't we
instead report the bug to upstream ffmpeg ?
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2015-06-14 20:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-14 17:11 [Buildroot] [PATCH 1/2] package/ffmpeg: Fix x86 compilation with gcc5 Bernd Kuhls
2015-06-14 17:11 ` [Buildroot] [PATCH 2/2] package/libgpg-error: Fix " Bernd Kuhls
2015-06-14 21:08 ` Thomas Petazzoni
2015-06-14 20:56 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150614225620.02eafcbc@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox