From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] Allow imagemagick to find ghostscript fonts.
Date: Tue, 16 Jun 2015 23:01:02 +0300 [thread overview]
Message-ID: <20150616200101.GB8165@tarshish> (raw)
In-Reply-To: <55806A8B.5090302@gmail.com>
Hi Robert,
On Tue, Jun 16, 2015 at 02:27:23PM -0400, grepper wrote:
> On 15/06/15 11:39 PM, Baruch Siach wrote:
> > On Mon, Jun 15, 2015 at 10:12:26PM -0400, grepper wrote:
> >> From: Robert Sohn <grepper@gmail.com>
> >>
> >> It appears that Imagemagick needs to be configured with
> >> --with-gs-font-dir=/usr/share/fonts/gs else it will not find
> >> the ghostscript fonts and /etc/ImageMagick-6/type-ghostscript.xml
> >> will contain the wrong font paths. You end up with messages like:
> >> Magick: unable to read font `(null)' @ error/annotate.c/RenderFreetype/1153
> >> They are non-fatal but could get annoying fast if you are using 'convert'
> >> on a lot of files.
> >>
> >> Signed-off-by: Robert Sohn <grepper@gmail.com>
> >> ---
> >> package/imagemagick/imagemagick.mk | 3 ++-
> >> 1 file changed, 2 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/package/imagemagick/imagemagick.mk b/package/imagemagick/imagemagick.mk
> >> index 298d0a8..1abb2a8 100644
> >> --- a/package/imagemagick/imagemagick.mk
> >> +++ b/package/imagemagick/imagemagick.mk
> >> @@ -33,7 +33,8 @@ IMAGEMAGICK_CONF_OPTS = \
> >> --without-dps \
> >> --without-gslib \
> >> --without-fpx \
> >> - --without-x
> >> + --without-x \
> >> + --with-gs-font-dir=/usr/share/fonts/gs
> >
> > These fonts are only available when the ghostscript-fonts is built, isn't it?
> > If so, then this should be
> >
> > ifeq ($(BR2_PACKAGE_GHOSTSCRIPT_FONTS),y)
> > IMAGEMAGICK_CONF_OPTS += --with-gs-font-dir=/usr/share/fonts/gs
> > endif
> >
> > Or maybe we should use $(GHOSTSCRIPT_FONTS_TARGET_DIR) here, instead of
> > duplicating it?
>
> Hm, the problem is that the issue will remain if ghostscript-fonts are
> not installed. I don't know the solution to that.
The usual way to set a dependency package is to add a 'select' statement for
that package in Config.in. In this case ghostscript-fonts is not a hard
dependency, because imagemagick is quite functional without it, and its size
is non negligible. Maybe adding a comment to the help text in Config.in would
suffice.
What do others think?
> It seems strange that imagemagick can not find a default font when 'convert
> -list font' shows many, ttf and otherwise.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
next prev parent reply other threads:[~2015-06-16 20:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-16 2:12 [Buildroot] [PATCH 1/1] Allow imagemagick to find ghostscript fonts grepper
2015-06-16 3:39 ` Baruch Siach
2015-06-16 18:27 ` grepper
2015-06-16 20:01 ` Baruch Siach [this message]
2015-12-29 16:45 ` Thomas Petazzoni
2016-07-04 15:50 ` Peter Korsgaard
-- strict thread matches above, loose matches on Subject: below --
2016-02-09 4:29 Ricardo Martincoski
2016-02-09 17:23 ` Yann E. MORIN
2016-02-09 18:16 ` Ricardo Martincoski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150616200101.GB8165@tarshish \
--to=baruch@tkos.co.il \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox