From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] openvmtools: fix legal info
Date: Sun, 21 Jun 2015 13:50:56 +0200 [thread overview]
Message-ID: <20150621115056.GB3625@free.fr> (raw)
In-Reply-To: <1434885903-22713-1-git-send-email-gustavo@zacarias.com.ar>
Gustavo, All,
On 2015-06-21 08:25 -0300, Gustavo Zacarias spake thusly:
> In ab71dff0 it was moved to SUBDIR, but this was never reflected for the
> legal-info files, update this to fix:
> http://autobuild.buildroot.net/results/836/8363943cc9c967713f585209408ea087a052a12d/
>
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
> ---
> package/openvmtools/openvmtools.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/openvmtools/openvmtools.mk b/package/openvmtools/openvmtools.mk
> index 9819640..e22153b 100644
> --- a/package/openvmtools/openvmtools.mk
> +++ b/package/openvmtools/openvmtools.mk
> @@ -7,7 +7,7 @@
> OPENVMTOOLS_VERSION = stable-9.10.0
> OPENVMTOOLS_SITE = $(call github,vmware,open-vm-tools,$(OPENVMTOOLS_VERSION))
> OPENVMTOOLS_LICENSE = LGPLv2.1
> -OPENVMTOOLS_LICENSE_FILES = COPYING
> +OPENVMTOOLS_LICENSE_FILES = $(OPENVMTOOLS_SUBDIR)/COPYING
I know this has no impact in Makefiles, but I prefer when we define
variables before we use them, it's easier to understand. So, I'd prefer
we define OPENVMTOOLS_SUBDIR before we use it.
Otherwise:
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> # Autoreconf needed or config/missing will run configure again at buildtime
> OPENVMTOOLS_AUTORECONF = YES
> OPENVMTOOLS_SUBDIR = open-vm-tools
> --
> 2.3.6
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2015-06-21 11:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-21 11:25 [Buildroot] [PATCH] openvmtools: fix legal info Gustavo Zacarias
2015-06-21 11:50 ` Yann E. MORIN [this message]
2015-06-21 12:05 ` Károly Kasza
2015-06-21 12:09 ` Gustavo Zacarias
2015-06-22 14:03 ` Luca Ceresoli
2015-06-22 14:05 ` Gustavo Zacarias
2015-06-22 14:09 ` Luca Ceresoli
2015-06-22 13:56 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150621115056.GB3625@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox