From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 03/11] package/rpi-firmware: add option to install vcdbg
Date: Mon, 29 Jun 2015 22:16:13 +0200 [thread overview]
Message-ID: <20150629221613.44f8b6be@free-electrons.com> (raw)
In-Reply-To: <20150629165240.GA3669@free.fr>
Dear Yann E. MORIN,
On Mon, 29 Jun 2015 18:52:40 +0200, Yann E. MORIN wrote:
> On 2015-06-29 06:19 +0300, Baruch Siach spake thusly:
> > On Mon, Jun 29, 2015 at 12:25:12AM +0200, Yann E. MORIN wrote:
> > > +config BR2_PACKAGE_RPI_FIRMWARE_INSTALL_VCDBG
> > > + bool "vcdbg"
> > > + depends on BR2_PACKAGE_RPI_USERLAND
> >
> > There must be a good reason for doing 'depends' instead of 'select' here. Can
> > you add a comment explaining that?
>
> OK, I can add a comment.
>
> Here's the reason: vcdbg is a debug utility, and I don't see selecting
> the whole of rpi-userland just for the one or two libraries that vcdbg
> xfr.org/requires.
Well, still, I believe a 'select' is more appropriate here. I don't
think we generally introduce a "depends on" because the dependency is a
little big. We really only do it when the dependency is quite obvious:
X.org, Python, etc.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-06-29 20:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-28 22:25 [Buildroot] [pull request] raspberrypi: update packages and defconfigs Yann E. MORIN
2015-06-28 22:25 ` [Buildroot] [PATCH 01/11] rpi-firmware: allow disabling installation of binary DTBs Yann E. MORIN
2015-06-28 22:25 ` [Buildroot] [PATCH 02/11] package/rpi-firmware: add option to install DTB overlays Yann E. MORIN
2015-06-28 22:25 ` [Buildroot] [PATCH 03/11] package/rpi-firmware: add option to install vcdbg Yann E. MORIN
2015-06-29 3:19 ` Baruch Siach
2015-06-29 16:52 ` Yann E. MORIN
2015-06-29 20:16 ` Thomas Petazzoni [this message]
2015-06-29 20:16 ` Thomas Petazzoni
2015-06-28 22:25 ` [Buildroot] [PATCH 04/11] package/rpi-firmware: bump version Yann E. MORIN
2015-06-28 22:25 ` [Buildroot] [PATCH 05/11] package/rpi-userland: " Yann E. MORIN
2015-06-28 22:25 ` [Buildroot] [PATCH 06/11] configs/raspberrypi: update the DT-enabled config Yann E. MORIN
2015-06-28 22:25 ` [Buildroot] [PATCH 07/11] configs/raspberrypi_plus: new defconfig Yann E. MORIN
2015-06-28 22:25 ` [Buildroot] [PATCH 08/11] configs/raspberrypi2: update our defconfig Yann E. MORIN
2015-06-28 22:25 ` [Buildroot] [PATCH 09/11] config/raspberrypi: remove non-DT defconfig Yann E. MORIN
2015-06-28 22:25 ` [Buildroot] [PATCH 10/11] config/raspberrypi: rename our defconfig files Yann E. MORIN
2015-06-28 22:25 ` [Buildroot] [PATCH 11/11] boards/raspberrypi: update instructions Yann E. MORIN
2015-06-29 20:22 ` [Buildroot] [pull request] raspberrypi: update packages and defconfigs Thomas Petazzoni
2015-06-29 20:26 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150629221613.44f8b6be@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox