From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] fs: add custom fakeroot script support
Date: Tue, 30 Jun 2015 15:31:13 +0200 [thread overview]
Message-ID: <20150630153113.65d445d6@free-electrons.com> (raw)
In-Reply-To: <1424865760.2629.14.camel@e37108.spectralink.com>
Stefan,
On Wed, 25 Feb 2015 12:02:41 +0000, S?rensen, Stefan wrote:
> > For file ownership, we already have BR2_ROOTFS_DEVICE_TABLE: "Path to
> > the permission tables". The naming of the option may be a bit
> > misleading, indeed, but that's historical...
>
> As you mention yourself, bulk ownership changes are problematic with
> device tables. Generating the device table in the post-build script
> doesn't seem very elegant to me.
Since commit
http://git.buildroot.net/buildroot/commit/package/makedevs?id=410f9b60137820143caf51a2a37da6f8fa16679f,
you can use the permission table to recursively set the
owernship/rights of a directory and all its subdirectories/files.
Therefore, I don't think this patch is needed, and I've marked it as
Rejected in our patch tracking system. Do not hesitate to repost an
updated version with a new justification if you don't agree, of course.
Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-06-30 13:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-24 15:47 [Buildroot] [PATCH 1/2] fs: Bail out on errors in fakeroot script Stefan Sørensen
2015-02-24 15:47 ` [Buildroot] [PATCH 2/2] fs: add custom fakeroot script support Stefan Sørensen
2015-02-24 21:39 ` Yann E. MORIN
2015-02-25 12:02 ` Sørensen, Stefan
2015-06-30 13:31 ` Thomas Petazzoni [this message]
2015-02-24 18:27 ` [Buildroot] [PATCH 1/2] fs: Bail out on errors in fakeroot script Yann E. MORIN
2015-03-08 21:23 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150630153113.65d445d6@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox