Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] util-linux: allow programs to be disabled by default
Date: Tue, 30 Jun 2015 22:59:15 +0200	[thread overview]
Message-ID: <20150630225915.6838f4f2@free-electrons.com> (raw)
In-Reply-To: <1435635368-26928-1-git-send-email-danomimanchego123@gmail.com>

Dear Danomi Manchego,

On Mon, 29 Jun 2015 23:36:08 -0400, Danomi Manchego wrote:

> +ifeq ($(BR2_PACKAGE_UTIL_LINUX_DISABLE_BY_DEFAULT),y)
> +UTIL_LINUX_CONF_OPTS += --disable-all-programs
> +endif

I understand the idea, but it's a bit weird to have an option to enable
to say that you want to disable everything.

Also, we are already passing --disable-all-programs when
BR2_PACKAGE_UTIL_LINUX_BINARIES is not enabled. Maybe we should instead
pass --disable-all-programs unconditionally. However this would change
the visible behavior for users, since programs that used to be built
would no longer be built. But it seems the most correct solution
nonetheless.

Any opinions from other Buildroot developers?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2015-06-30 20:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-30  3:36 [Buildroot] [PATCH 1/1] util-linux: allow programs to be disabled by default Danomi Manchego
2015-06-30 20:59 ` Thomas Petazzoni [this message]
2015-06-30 21:35   ` Danomi Manchego
2015-07-07 21:01     ` Arnout Vandecappelle
2015-07-07 21:32     ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150630225915.6838f4f2@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox