From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] force rsync of local package and try to rebuild it with its dependencies
Date: Thu, 2 Jul 2015 12:35:28 +0200 [thread overview]
Message-ID: <20150702123528.1d32089a@free-electrons.com> (raw)
In-Reply-To: <1435828515-16620-1-git-send-email-viallard@syscom-instruments.com>
Dear Anthony Viallard,
On Thu, 2 Jul 2015 11:15:15 +0200, Anthony Viallard wrote:
> The purpose of this patch is to force rsync of local site packages and
> rebuild them if their source code has changed. Therefore, if the source
> of a package has changed, it will be rebuild if you type make or
> make <pkg>. Likewise, if a package has a library dependency which is
> local site package too and you type make <pkg>, the library will be
> rebuild if the source has been modified.
>
> This behavior is pretty useful if you use buildroot with many of your
> own packages. Especially if you share these packages with a developer
> team through a version control system like git.
Again, I don't think we want this change in Buildroot. I don't think we
want *all* local packages to systematically be rsync'ed and rebuilt, at
every "make" invocation.
Maybe we want a separate "make rebuild-local" target (not sure of the
name), which would trigger this special action. Local packages could be
all registered in a global LOCAL_PACKAGES variable, and make
rebuild-local would rebuild them all.
Note that you could also solve this problem by adding something like
that in your external.mk (provided you're using BR2_EXTERNAL):
# Needs to be filled in with your complete list of packages
CUSTOM_PACKAGES = foo1 foo2 foo3
rebuild-custom: $(foreach p,$(CUSTOM_PACKAGES),$(p))
> - rsync -au $(RSYNC_VCS_EXCLUSIONS) $(SRCDIR)/ $(@D)
> + rsync -au $(RSYNC_VCS_EXCLUSIONS) --include core $(SRCDIR)/ $(@D)
This change is unrelated to the patch I believe.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-07-02 10:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-02 9:15 [Buildroot] [PATCH 1/1] force rsync of local package and try to rebuild it with its dependencies Anthony Viallard
2015-07-02 10:35 ` Thomas Petazzoni [this message]
2015-07-02 21:22 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150702123528.1d32089a@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox