From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/pkg-kconfig: define KCONFIG_EDITORS_MAKE_ENV
Date: Thu, 2 Jul 2015 23:20:32 +0200 [thread overview]
Message-ID: <20150702212031.GH3838@free.fr> (raw)
In-Reply-To: <20150702175937.4733d060@free-electrons.com>
Tal, All,
On 2015-07-02 17:59 +0200, Thomas Petazzoni spake thusly:
> On Thu, 2 Jul 2015 17:41:40 +0300, Tal Zilcer wrote:
>
> > $$(addprefix $(1)-,$$($(2)_KCONFIG_EDITORS)): @D=$$($(2)_DIR)
> > $$(addprefix $(1)-,$$($(2)_KCONFIG_EDITORS)): $$($(2)_DIR)/.stamp_kconfig_fixup_done
> > - $$($(2)_MAKE_ENV) $$(MAKE) -C $$($(2)_DIR) \
> > + $$($(2)_KCONFIG_EDITORS_MAKE_ENV) $$(MAKE) -C $$($(2)_DIR) \
>
> I actually don't think adding a KCONFIG_EDITORS_MAKE_ENV variable is
> really useful here. Since it's a bunch of host tools, maybe we should
> just:
>
> $$(HOST_MAKE_ENV) $$(MAKE) -C ...
I do agree with Thomas here.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2015-07-02 21:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-02 14:41 [Buildroot] [PATCH 1/1] package/pkg-kconfig: define KCONFIG_EDITORS_MAKE_ENV Tal Zilcer
2015-07-02 15:59 ` Thomas Petazzoni
2015-07-02 21:20 ` Yann E. MORIN [this message]
2015-07-04 12:30 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150702212031.GH3838@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox