From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] core/pkg-generic: sanitise FOO_OVERRIDE_SRCDIR
Date: Sat, 4 Jul 2015 15:33:03 +0200 [thread overview]
Message-ID: <20150704153303.36e35ef2@free-electrons.com> (raw)
In-Reply-To: <1435494449-12837-1-git-send-email-yann.morin.1998@free.fr>
Dear Yann E. MORIN,
On Sun, 28 Jun 2015 14:27:29 +0200, Yann E. MORIN wrote:
> In case FOO_OVERRIDE_SRCDIR has trailing spaces, like so:
> FOO_OVERRIDE_SRCDIR = /path/to/sources\x20
>
> we would end up with a rsync command like so:
> rsync -au /path/to/sources / /path/to/build/foo
>
> which would effectively rsync the whole vfs, eventually filling the
> whole disk... :-(
>
> So, just qstrip the variable before use.
>
> Reported-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> ---
> package/pkg-generic.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2015-07-04 13:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-28 12:27 [Buildroot] [PATCH] core/pkg-generic: sanitise FOO_OVERRIDE_SRCDIR Yann E. MORIN
2015-07-04 13:33 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150704153303.36e35ef2@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox