Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] collectd: fix parallel build issues
Date: Mon, 6 Jul 2015 15:22:50 +0200	[thread overview]
Message-ID: <20150706152250.54ec1b86@free-electrons.com> (raw)
In-Reply-To: <1436188343-11234-1-git-send-email-gustavo@zacarias.com.ar>

Dear Gustavo Zacarias,

On Mon,  6 Jul 2015 10:12:23 -0300, Gustavo Zacarias wrote:

> +diff -Nura collectd-5.5.0.orig/src/daemon/Makefile.am collectd-5.5.0/src/daemon/Makefile.am
> +--- collectd-5.5.0.orig/src/daemon/Makefile.am	2015-07-06 10:01:17.820506239 -0300
> ++++ collectd-5.5.0/src/daemon/Makefile.am	2015-07-06 10:02:03.364054763 -0300
> +@@ -49,7 +49,7 @@
> + collectd_CFLAGS = $(AM_CFLAGS)
> + collectd_LDFLAGS = -export-dynamic
> + collectd_LDADD = libavltree.la libcommon.la libheap.la -lm
> +-collectd_DEPENDENCIES =
> ++collectd_DEPENDENCIES = libavltree.la libcommon.la libheap.la

Can you try instead to get rid of the empty collectd_DEPENDENCIES
definition? Because when undefined foo_DEPENDENCIES automatically
contains the contents of foo_LDADD.

From
http://www.gnu.org/software/automake/manual/html_node/Program-and-Library-Variables.html:

"""
If _DEPENDENCIES is not supplied, it is computed by Automake. The
automatically-assigned value is the contents of _LDADD or _LIBADD, with
most configure substitutions, -l, -L, -dlopen and -dlpreopen options
removed. The configure substitutions that are left in are only
?$(LIBOBJS)? and ?$(ALLOCA)?; these are left because it is known that
they will not cause an invalid value for _DEPENDENCIES to be generated.
"""

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2015-07-06 13:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-06 13:12 [Buildroot] [PATCH] collectd: fix parallel build issues Gustavo Zacarias
2015-07-06 13:22 ` Thomas Petazzoni [this message]
2015-07-06 13:33   ` Gustavo Zacarias
2015-07-06 13:38     ` Thomas Petazzoni
2015-07-06 13:43       ` Gustavo Zacarias
2015-07-06 13:48 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150706152250.54ec1b86@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox