Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/linux-firmware: add missing nvs file for the wl18xx firmware
Date: Wed, 8 Jul 2015 22:15:15 +0200	[thread overview]
Message-ID: <20150708201515.GB3547@free.fr> (raw)
In-Reply-To: <1436380795-30694-1-git-send-email-mac@vrvana.com>

Marc-Andre, All,

On 2015-07-08 14:39 -0400, Marc-Andre Chenier spake thusly:
> Signed-off-by: Marc-Andre Chenier <mac@vrvana.com>

Indeed, wl18xx depends on wlcore, which needs hat firmware file.

But see comments below...

> ---
>  package/linux-firmware/linux-firmware.mk | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/package/linux-firmware/linux-firmware.mk b/package/linux-firmware/linux-firmware.mk
> index 25a942a..f35dba5 100644
> --- a/package/linux-firmware/linux-firmware.mk
> +++ b/package/linux-firmware/linux-firmware.mk
> @@ -178,7 +178,10 @@ LINUX_FIRMWARE_FILES += \
>  	ti-connectivity/wl18xx-fw-2.bin \
>  	ti-connectivity/wl18xx-fw-3.bin \
>  	ti-connectivity/wl18xx-fw-4.bin \
> +	ti-connectivity/wl1271-nvs.bin \
>  	ti-connectivity/TIInit_7.2.31.bts
> +# wl1271-nvs.bin (above) is a symlink to:
> +LINUX_FIRMWARE_FILES += ti-connectivity/wl127x-nvs.bin

Just put the two in the same list; keep the comment and move it to the
top of the existing list.

BTW, that symlink is not prsent in the other two TI wl127x and 128x
lists, just above the one you modified. Is it not needed for those two,
or did we forget to add it?

If the latter, can you fix that when you re-spin your patch, please?

Thanks! :-)

Regards,
Yann E. MORIN.

>  LINUX_FIRMWARE_ALL_LICENSE_FILES += LICENCE.ti-connectivity
>  endif
>  
> -- 
> 2.4.5
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2015-07-08 20:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-08 18:39 [Buildroot] [PATCH 1/1] package/linux-firmware: add missing nvs file for the wl18xx firmware Marc-Andre Chenier
2015-07-08 20:15 ` Yann E. MORIN [this message]
2015-07-09  0:06   ` Marc-André Chénier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150708201515.GB3547@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox