From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Sun, 12 Jul 2015 00:50:51 +0200 Subject: [Buildroot] [PATCH v3] pkg-generic: Fix host _DL_VERSION corner case In-Reply-To: <1436629214-32106-1-git-send-email-arnout@mind.be> References: <1436628092-30192-1-git-send-email-arnout@mind.be> <1436629214-32106-1-git-send-email-arnout@mind.be> Message-ID: <20150712005051.528b8bd2@free-electrons.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Dear Arnout Vandecappelle (Essensium/Mind), On Sat, 11 Jul 2015 17:40:14 +0200, Arnout Vandecappelle (Essensium/Mind) wrote: > From: Clayton Shotwell > > In the case when a package has a host version, the package is dependent > on the host version, and the version contains a '/', the host version > does not evaluate properly. The host version will contain a '_' instead > of a '/', resulting in a failed download. To solve this corner case, add > a check to see if the _DL_VERSION of the package has been defined before > defining the host _DL_VERSION. If the package _DL_VERSION has not been > defined yet, then the version string has not been formatted yet and is > still good to use. > > [Arnout: further simplify things by lifting the override over _VERSION > out of the condition - it is always the same.] > > This error occured on a package in a BR2_EXTERNAL that uses a git repo > for its remote storage with '/' in the tag names. I do not believe this > affects any packages in the Buildroot mainline but it could in the > future. > > [Arnout: rebase on master, fix existing whitespace error in the else > branch.] > > Signed-off-by: Clayton Shotwell > Signed-off-by: Arnout Vandecappelle (Essensium/Mind) > --- > v3: Re-instate Clayton as author - sorry about that > v2: rebase, fix whitespace error, lift _VERSION assignment out of condition > --- > package/pkg-generic.mk | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) Applied, thanks. Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com