From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] package/perf: build outside kernel tree
Date: Sun, 12 Jul 2015 01:11:58 +0200 [thread overview]
Message-ID: <20150712011158.3aab2b47@free-electrons.com> (raw)
In-Reply-To: <1426762651-7734-1-git-send-email-steven@uplinklabs.net>
Dear Steven Noonan,
On Thu, 19 Mar 2015 03:57:31 -0700, Steven Noonan wrote:
> This is necessary for introducing patches.
>
> Signed-off-by: Steven Noonan <steven@uplinklabs.net>
> ---
>
> v2:
> - Running 'make source' made me realize that the PERF_SOURCE variable needed
> to be added, pointing to the same location as e.g. linux-headers.
>
> package/perf/perf.mk | 23 ++++++++++++++---------
> 1 file changed, 14 insertions(+), 9 deletions(-)
>
> diff --git a/package/perf/perf.mk b/package/perf/perf.mk
> index f35abc9..2177ac8 100644
> --- a/package/perf/perf.mk
> +++ b/package/perf/perf.mk
> @@ -5,10 +5,15 @@
> ################################################################################
>
> # Source taken from the Linux kernel tree
> -PERF_SOURCE =
> PERF_VERSION = $(call qstrip,$(BR2_LINUX_KERNEL_VERSION))
> +PERF_SOURCE = linux-$(PERF_VERSION).tar.xz
> +ifeq ($(findstring x2.6.,x$(PERF_VERSION)),x2.6.)
> +PERF_SITE = $(BR2_KERNEL_MIRROR)/linux/kernel/v2.6
> +else
> +PERF_SITE = $(BR2_KERNEL_MIRROR)/linux/kernel/v3.x
> +endif
Unfortunately, this works only if an upstream kernel tarball is
selected. However, that's not really the case in many situations: a lot
of people use tarballs from custom locations, or a kernel coming from a
Git repository. And for all those cases, your definition of PERF_SITE
will not work.
The simplest solution is quite probably to apply your perf patches to
your kernel tree. You can use BR2_GLOBAL_PATCH_DIR to apply custom
patches to your kernel tree.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2015-07-11 23:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-19 10:57 [Buildroot] [PATCH v2] package/perf: build outside kernel tree Steven Noonan
2015-03-19 11:02 ` Baruch Siach
2015-03-19 11:04 ` Steven Noonan
2015-03-19 11:21 ` Baruch Siach
2015-03-19 12:15 ` Thomas Petazzoni
2015-03-19 12:46 ` Steven Noonan
2015-07-11 23:11 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150712011158.3aab2b47@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox