Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [RFC PATCH v2 0/5] Add ILP32 support in aarch64
Date: Sun, 12 Jul 2015 18:45:59 +0200	[thread overview]
Message-ID: <20150712184559.581d42c0@free-electrons.com> (raw)
In-Reply-To: <1426672192-21041-1-git-send-email-bamvor.zhangjian@huawei.com>

Dear Zhang Jian(Bamvor),

On Wed, 18 Mar 2015 17:49:47 +0800, Zhang Jian(Bamvor) wrote:

> Zhang Jian(Bamvor) (5):
>   aarch64: add big endian(aarch64_be) support

I've now applied this patch. However it is not complete enough: you
need to audit all the places where BR2_aarch64 is used in Buildroot,
and see whether adding BR2_aarch64_be is needed. For example, in
package/binutils/Config.in.host:

        config BR2_BINUTILS_VERSION_2_23_2
                depends on !BR2_aarch64 && !BR2_microblaze && \
                           !BR2_powerpc64le && !BR2_nios2
                bool "binutils 2.23.2"

You quite probably want to add !BR2_aarch64_be here as well.

>   aarch64: ilp32: handle special file name
>   aarch64: ilp32: add ilp32 compiler and linker flags
>   aarch64: ilp32: add ilp32 build config
>   aarch64: ilp32 defconfig examples

For those patches, you had some comments. A while ago, when I sent you
a reminder about those patches, you said you would resend an updated
version, but this didn't happen. For now, we marked those patches as
"Changes Requested" in patchwork. Do not hesitate to resend a new
version.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  parent reply	other threads:[~2015-07-12 16:45 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-18  9:49 [Buildroot] [RFC PATCH v2 0/5] Add ILP32 support in aarch64 Zhang Jian
2015-03-18  9:49 ` [Buildroot] [RFC PATCH v2 1/5] aarch64: add big endian(aarch64_be) support Zhang Jian
2015-04-10 12:24   ` Gustavo Zacarias
2015-03-18  9:49 ` [Buildroot] [RFC PATCH v2 2/5] aarch64: ilp32: handle special file name Zhang Jian
2015-04-10 12:35   ` Gustavo Zacarias
2015-04-13 10:12     ` Bamvor Jian Zhang
2015-04-13 10:16       ` Bamvor Jian Zhang
2015-03-18  9:49 ` [Buildroot] [RFC PATCH v2 3/5] aarch64: ilp32: add ilp32 compiler and linker flags Zhang Jian
2015-04-10 12:36   ` Gustavo Zacarias
2015-04-13 10:06     ` Bamvor Jian Zhang
2015-03-18  9:49 ` [Buildroot] [RFC PATCH v2 4/5] aarch64: ilp32: add ilp32 build config Zhang Jian
2015-04-10 12:46   ` Gustavo Zacarias
2015-04-13 10:02     ` Bamvor Jian Zhang
2015-03-18  9:49 ` [Buildroot] [RFC PATCH v2 5/5] aarch64: ilp32 defconfig examples Zhang Jian
2015-04-10  9:16 ` [Buildroot] [RFC PATCH v2 0/5] Add ILP32 support in aarch64 Bamvor Jian Zhang
2015-07-12 16:45 ` Thomas Petazzoni [this message]
2015-07-13  2:21   ` Zhangjian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150712184559.581d42c0@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox