From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 7/7] package/uclibc: check for config file before calling kconfig-package
Date: Sun, 12 Jul 2015 23:06:36 +0300 [thread overview]
Message-ID: <20150712200636.GC2451@tarshish> (raw)
In-Reply-To: <62fed5cb399404addb30c60c3dc128f46333c9ec.1436702899.git.yann.morin.1998@free.fr>
Hi Yann,
On Sun, Jul 12, 2015 at 02:11:29PM +0200, Yann E. MORIN wrote:
> If we check that the user provides a config file after we call to the
> kconfig-package infra, the error message we get is the one for the
> kconfig-package infra, not the custom error message we want to show to
> the user.
>
> So, only call kconfig-package after we do the check.
The commit log doesn't match the patch. There was no error message before this
patch, AFAICS.
baruch
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> ---
> package/uclibc/uclibc.mk | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/package/uclibc/uclibc.mk b/package/uclibc/uclibc.mk
> index ecbfa11..7dee6b3 100644
> --- a/package/uclibc/uclibc.mk
> +++ b/package/uclibc/uclibc.mk
> @@ -474,4 +474,10 @@ define UCLIBC_INSTALL_STAGING_CMDS
> $(UCLIBC_INSTALL_UTILS_STAGING)
> endef
>
> +# Checks to give errors that the user can understand
> +# Must be before we call to kconfig-package
> +ifeq ($(BR_BUILDING)$(call qstrip,$(BR2_PACKAGE_BUSYBOX_CONFIG)),y)
> +$(error No uClibc configuration file specified, check your BR2_UCLIBC_CONFIG setting)
> +endif
> +
> $(eval $(kconfig-package))
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
prev parent reply other threads:[~2015-07-12 20:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-12 12:11 [Buildroot] [PATCH 0/7] core/kconfig: fix display of custom error messages (branch yem/misc) Yann E. MORIN
2015-07-12 12:11 ` [Buildroot] [PATCH 1/7] core/pkg-kconfig: don't enforce check for config file when not building Yann E. MORIN
2015-07-12 12:11 ` [Buildroot] [PATCH 2/7] package/linux: don't enforce check for DTS " Yann E. MORIN
2015-07-12 20:03 ` Baruch Siach
2015-07-12 23:44 ` Arnout Vandecappelle
2015-07-13 3:37 ` Baruch Siach
2015-07-13 7:18 ` Yann E. MORIN
2015-07-12 12:11 ` [Buildroot] [PATCH 3/7] boot/at91boostrap3: check for config file before calling kconfig-package Yann E. MORIN
2015-07-12 12:11 ` [Buildroot] [PATCH 4/7] boot/barebox: " Yann E. MORIN
2015-07-12 12:11 ` [Buildroot] [PATCH 5/7] package/linux: " Yann E. MORIN
2015-07-12 12:11 ` [Buildroot] [PATCH 6/7] package/busybox: " Yann E. MORIN
2015-07-12 12:11 ` [Buildroot] [PATCH 7/7] package/uclibc: " Yann E. MORIN
2015-07-12 20:06 ` Baruch Siach [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150712200636.GC2451@tarshish \
--to=baruch@tkos.co.il \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox