From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4 2/9] Makefile: don't depend on current skeleton/overlay permissions
Date: Mon, 13 Jul 2015 17:02:45 +0200 [thread overview]
Message-ID: <20150713170245.42cbf089@free-electrons.com> (raw)
In-Reply-To: <1416586748-12936-3-git-send-email-guido@vanguardiasur.com.ar>
Dear Guido Mart?nez,
On Fri, 21 Nov 2014 13:19:01 -0300, Guido Mart?nez wrote:
> We use 'rsync -a' to copy the skeleton and overlays, so the target ends
> up with the exact same permissions as on the repo. The problem is we
> don't track these permissions, since Git doesn't allow for that (except
> for the exec bit). This means users with different umasks at the time of
> cloning could end up with different target permissions.
>
> Fix this by using --chmod on rsync calls so we don't depend on the
> current permission set for the skeleton and overlays. We do depend on
> the exec bit, but that's fine since that one is tracked by Git.
>
> Signed-off-by: Guido Mart?nez <guido@vanguardiasur.com.ar>
> ---
> Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-07-13 15:02 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-21 16:18 [Buildroot] [PATCH v4 0/9] target permissions Guido Martínez
2014-11-21 16:19 ` [Buildroot] [PATCH v4 1/9] Makefile: don't depend on the umask Guido Martínez
2015-07-13 9:35 ` Arnout Vandecappelle
2015-07-13 10:59 ` Thomas Petazzoni
2014-11-21 16:19 ` [Buildroot] [PATCH v4 2/9] Makefile: don't depend on current skeleton/overlay permissions Guido Martínez
2015-07-13 11:35 ` Arnout Vandecappelle
2015-07-13 11:36 ` [Buildroot] [PATCH] CHANGES: add release note for the permissions Arnout Vandecappelle
2015-07-13 11:39 ` Baruch Siach
2015-07-13 15:03 ` Thomas Petazzoni
2015-07-13 15:02 ` Thomas Petazzoni [this message]
2014-11-21 16:19 ` [Buildroot] [PATCH v4 3/9] toolchain/helpers.mk: use --chmod on rsync Guido Martínez
2015-07-13 15:07 ` Arnout Vandecappelle
2015-07-13 15:13 ` Thomas Petazzoni
2014-11-21 16:19 ` [Buildroot] [PATCH v4 4/9] pkg-generic.mk: don't depend on external package permissions Guido Martínez
2015-07-13 15:19 ` Thomas Petazzoni
2014-11-21 16:19 ` [Buildroot] [PATCH v4 5/9] package: matchbox-keyboard: use install instead of cp Guido Martínez
2014-11-22 18:47 ` Thomas Petazzoni
2014-11-21 16:19 ` [Buildroot] [PATCH v4 6/9] scripts: mkmakefile: set umask before calling BR's makefile Guido Martínez
2015-07-13 15:20 ` Thomas Petazzoni
2014-11-21 16:19 ` [Buildroot] [PATCH v4 7/9] nitrogen6x: use install instead of cp Guido Martínez
2014-11-21 16:19 ` [Buildroot] [PATCH v4 8/9] boot/grub: " Guido Martínez
2014-11-21 16:19 ` [Buildroot] [PATCH v4 9/9] fs/iso9660: " Guido Martínez
2014-11-22 18:02 ` [Buildroot] [PATCH v4 0/9] target permissions Thomas Petazzoni
2014-11-25 23:01 ` Guido Martínez
2014-11-24 22:17 ` Ezequiel Garcia
2014-12-03 18:07 ` Guido Martínez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150713170245.42cbf089@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox