Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/qpid-proton: needs host-python2
Date: Tue, 14 Jul 2015 15:03:25 +0300	[thread overview]
Message-ID: <20150714120325.GB2332@tarshish> (raw)
In-Reply-To: <20150714135627.26cf899a@free-electrons.com>

Hi Thomas,

On Tue, Jul 14, 2015 at 01:56:27PM +0200, Thomas Petazzoni wrote:
> On Tue, 14 Jul 2015 14:48:04 +0300, Baruch Siach wrote:
> > My interpretation of the cmake log is that cmake uses the python 
> > interpreter it detects to run the scripts. In the failed cases cmake 
> > detected host-python3 because host-python3 happened to build before 
> > qpid-proton. cmake did not use the distro installed host python even 
> > though it's python2 (most likely). So I'm not sure patching the scripts is 
> > necessary.
> 
> It is necessary if your host machine has a Python 3 interpreter and not
> a Python 2 interpreter. In this case the scripts will
> run /usr/bin/python (because it's hardcoded in their source code), and
> this will run Python 3.
> 
> So Yann's solution looks good. Am I missing something?

My point is that in the failed cases /usr/bin/python was not used, otherwise 
the build would have succeeded. It seems that cmake uses the python 
interpreter it detects to run the scripts. So patching the scripts doesn't 
change anything by itself, IIUC.

Related to this, what do you thing about changing the host python requirement 
in the manual?

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

  reply	other threads:[~2015-07-14 12:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-14 11:38 [Buildroot] [PATCH] package/qpid-proton: needs host-python2 Yann E. MORIN
2015-07-14 11:48 ` Baruch Siach
2015-07-14 11:56   ` Thomas Petazzoni
2015-07-14 12:03     ` Baruch Siach [this message]
2015-07-14 12:42       ` Yann E. MORIN
2015-07-14 13:59       ` Yann E. MORIN
2015-07-14 15:43       ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150714120325.GB2332@tarshish \
    --to=baruch@tkos.co.il \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox