From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/1] gmock: new package
Date: Tue, 14 Jul 2015 12:23:29 +0200 [thread overview]
Message-ID: <20150714122329.2b58433d@free-electrons.com> (raw)
In-Reply-To: <CAHXCMML+4JgBr1msNmu8Z4Ja0FjmR1TficJq4d5nfnPXaXTg6A@mail.gmail.com>
Samuel, Carlos,
On Tue, 14 Jul 2015 12:09:34 +0200, Samuel Martin wrote:
> > +################################################################################
> > +#
> > +# gmock
> > +#
> > +################################################################################
> > +
> > +GMOCK_VERSION = 1.7.0
> According to [1], gmock version must be the same as the gtest's one,
> so maybe we should do:
> GMOCK_VERSION = $(GTEST_VERSION)
> (but, taking care of the *.mk inclusion to get GTEST_VERSION defined
> before including gmock.mk).
I don't think this is a good idea. gmock is included *before* gtest,
and there's not much that can be done about this.
So instead, I would recommend to just to:
# Make sure this remains the same version as the gtest one
GMOCK_VERSION = 1.7.0
and then in gtest.mk:
# Make sure this remains the same version as the gmock one
GTEST_VERSION = 1.7.0
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-07-14 10:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-02 14:01 [Buildroot] [PATCH 0/1] gmock: new package Carlos Santos
2015-03-02 14:01 ` [Buildroot] [PATCH 1/1] " Carlos Santos
2015-04-19 11:03 ` Fabio Porcedda
2015-04-27 21:52 ` Thomas Petazzoni
2015-05-15 18:05 ` [Buildroot] [PATCH v2 " Carlos Santos
2015-07-14 10:09 ` Samuel Martin
2015-07-14 10:23 ` Thomas Petazzoni [this message]
2015-07-16 11:34 ` Carlos Santos
2015-07-16 20:51 ` Carlos Santos
2015-07-16 22:57 ` Samuel Martin
2015-07-23 20:39 ` [Buildroot] [PATCH V3 " Carlos Santos
2015-07-28 15:42 ` Romain Naour
2015-07-31 11:53 ` [Buildroot] [PATCH V4 " Carlos Santos
2015-07-31 14:06 ` Romain Naour
2015-09-17 19:21 ` Carlos Santos
2015-10-03 15:14 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150714122329.2b58433d@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox