Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCHv4] Makefile: fix performance regression casued by the umask handling
Date: Fri, 17 Jul 2015 18:47:27 +0200	[thread overview]
Message-ID: <20150717164727.GB3637@free.fr> (raw)
In-Reply-To: <55A83195.8080204@mind.be>

Arnout, Guido, All,

On 2015-07-17 00:35 +0200, Arnout Vandecappelle spake thusly:
> On 07/17/15 00:33, Yann E. MORIN wrote:
> > From: Guido Mart?nez <guido@vanguardiasur.com.ar>
> > 
> > Commit bee5745c introduced an extra level of 'make' when the umask is
> > different from 0022. However, when several targets were specified on
> > the command line, a new make instance would be called for each target.
> > This introduces a huge performance overhead when many targets are
> > specified on the command line.
> > 
> > To fix this, use the same approach as used in the mkmakefile script:
> > an addition target on which the MAKECMDGOALS depend, so that this
> > target is run only once.
> > 
> > Note that the mkmakefile script contains a special exception for
> > Makefile, because the Makefile in the output directory is generated.
> > Since the top-level Makefile is not generated, this exception is not
> > needed here.
> > 
> > While we're at it, also fix the whitespace in the UMASK assignment.
> > 
> > Signed-off-by: Guido Mart?nez <guido@vanguardiasur.com.ar>
> > Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> > [yann.morin.1998 at free.fr: aggregate patches from Arnout and Guido]
> > Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> 
> Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> 
>  Someone finally got it right :-)

Almost... I made a typo in the subject... ;-]

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2015-07-17 16:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-16 22:33 [Buildroot] [PATCHv4] Makefile: fix performance regression casued by the umask handling Yann E. MORIN
2015-07-16 22:35 ` Arnout Vandecappelle
2015-07-17 16:47   ` Yann E. MORIN [this message]
2015-07-18  9:31 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150717164727.GB3637@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox