From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] ARC: update tools to arc-2015.06 release
Date: Sat, 18 Jul 2015 00:54:15 +0200 [thread overview]
Message-ID: <20150717225415.GF3637@free.fr> (raw)
In-Reply-To: <20150717222354.GE3637@free.fr>
Romain, All,
On 2015-07-18 00:23 +0200, Yann E. MORIN spake thusly:
> On 2015-07-17 13:45 +0200, Romain Naour spake thusly:
> [--SNIP--]
> > Your patch looks good, but I have a build failure with uclibc:
> >
> > make O=test/arc/ toolchain 2>&1 | tee build-arc-toolchain.log
[--SNIP--]
> OK, I was able to reproduce the error. [...]
Here's a patch that does fix the issue.
Tested on-top of master, with:
- in-tree build
- out-of-tree build without makefile wrapper (Romain's use-case)
- out-of-tree build with makefile wrapper (my use-case)
They all worked at least so far as to build uclibc (make uclibc);
nothing more was attempted).
The change is not unlike what we already had to test where O was coming
from, but we just reverse the logic to keep only what we're interested
in, and we forcibly unexport O.
I'm not really happy with the patch to start with (hence I'm not
officially pushing it):
diff --git a/Makefile b/Makefile
index 531ac5d..5abca65 100644
--- a/Makefile
+++ b/Makefile
@@ -29,11 +29,16 @@ UMASK=0022
ifneq ($(shell umask),$(UMASK))
.PHONY: all $(MAKECMDGOALS)
+ifeq ($(origin O),command line)
+EXTRAMAKEARGS = O=$(O)
+endif
+unexport O
+
all:
- @umask $(UMASK) && $(MAKE ) --no-print-directory
+ @umask $(UMASK) && $(MAKE) $(EXTRAMAKEARGS) -- no-print-directory
$(MAKECMDGOALS):
- @umask $(UMASK) && $(MAKE) --n o-print-directory $@
+ @umask $(UMASK) && $(MAKE) $(EXTRAMAKEARGS) --no -print-directory $@
else # umask
I'll let a night pass by on this and maybe I'll have a cleaner solution
tomorrow.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2015-07-17 22:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-15 12:51 [Buildroot] [PATCH] ARC: update tools to arc-2015.06 release Alexey Brodkin
2015-07-17 11:45 ` Romain Naour
2015-07-17 11:55 ` Romain Naour
2015-07-17 15:38 ` Alexey Brodkin
2015-07-17 17:24 ` Romain Naour
2015-07-17 22:23 ` Yann E. MORIN
2015-07-17 22:54 ` Yann E. MORIN [this message]
2015-07-18 3:17 ` Guido Martínez
2015-07-25 9:24 ` Romain Naour
2015-07-18 9:14 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150717225415.GF3637@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox