Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] rtl8188eu: new package
Date: Sat, 18 Jul 2015 23:30:12 +0200	[thread overview]
Message-ID: <20150718233012.5293b49f@free-electrons.com> (raw)
In-Reply-To: <1436188175-7912-2-git-send-email-luca@lucaceresoli.net>

Dear Luca Ceresoli,

On Mon,  6 Jul 2015 15:09:35 +0200, Luca Ceresoli wrote:

> diff --git a/package/rtl8188eu/rtl8188eu.mk b/package/rtl8188eu/rtl8188eu.mk
> new file mode 100644
> index 0000000..843d9b0
> --- /dev/null
> +++ b/package/rtl8188eu/rtl8188eu.mk
> @@ -0,0 +1,22 @@
> +################################################################################
> +#
> +# rtl8188eu
> +#
> +################################################################################
> +
> +RTL8188EU_VERSION = 3091828c8f4b4a01cbec6025128bf77e6e7b9f97
> +RTL8188EU_SITE = $(call github,lwfinger,rtl8188eu,$(RTL8188EU_VERSION))
> +RTL8188EU_DEPENDENCIES = linux
> +RTL8188EU_LICENSE = GPLv2
> +RTL8188EU_LICENSE_FILES = COPYING
> +
> +define RTL8188EU_BUILD_CMDS
> +	$(MAKE) -C $(@D) $(LINUX_MAKE_FLAGS) KSRC=$(LINUX_DIR)
> +endef
> +
> +define RTL8188EU_INSTALL_TARGET_CMDS
> +	$(MAKE) -C $(@D) $(LINUX_MAKE_FLAGS) KSRC=$(LINUX_DIR) \
> +		modules_install firmware_install
> +endef
> +
> +$(eval $(generic-package))

In addition to the previous discussion, this package should also
probably be using the new kernel-module infrastructure.

Can you respin a new version? In the mean time, I'll mark this one as
"Changes Requested" in patchwork.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  parent reply	other threads:[~2015-07-18 21:30 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-06 13:09 [Buildroot] [PATCH 1/2] system: allow using mdev for firmware loading only Luca Ceresoli
2015-07-06 13:09 ` [Buildroot] [PATCH 2/2] rtl8188eu: new package Luca Ceresoli
2015-07-06 13:17   ` Thomas Petazzoni
2015-07-06 13:59     ` Luca Ceresoli
2015-07-06 14:36       ` Thomas Petazzoni
2015-07-18 21:30   ` Thomas Petazzoni [this message]
2015-07-21 16:26     ` Luca Ceresoli
2015-07-21 20:57       ` Thomas Petazzoni
2015-07-22 10:17         ` Luca Ceresoli
2015-07-22 11:26           ` Thomas Petazzoni
2015-07-06 13:49 ` [Buildroot] [PATCH 1/2] system: allow using mdev for firmware loading only Thomas Petazzoni
2015-07-06 14:08   ` Luca Ceresoli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150718233012.5293b49f@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox