From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] quazip: new package
Date: Sat, 18 Jul 2015 23:51:40 +0200 [thread overview]
Message-ID: <20150718235140.5a4eb571@free-electrons.com> (raw)
In-Reply-To: <1436747889-23748-1-git-send-email-mr.zoltan.gyarmati@gmail.com>
Dear Zoltan Gyarmati,
On Mon, 13 Jul 2015 02:38:09 +0200, Zoltan Gyarmati wrote:
> Signed-off-by: Zoltan Gyarmati <mr.zoltan.gyarmati@gmail.com>
> ---
> Changes v1 -> v2:
> - correct license file name
I've applied, but there were still lots of things I had to fix before
applying. Here are the details:
[Thomas:
- fix indentation of select BR2_PACKAGE_ZLIB in Config.in
- rewrap Config.in help text, lines were too long
- remove depends on BR2_PACKAGE_QT || BR2_PACKAGE_QT5, since
quazip/Config.in is already only included if one of Qt4 or Qt5 is
enabled.
- remove QUAZIP_SOURCE definition, since its value was the default
- add the missing zlib dependency in the .mk file
- add spaces around '=' signs when setting QUAZIP_QMAKE
- pass $(TARGET_MAKE_ENV) at install time]
You can look at the final commit at
http://git.buildroot.net/buildroot/commit/?id=40f0c0c122bd93fc835a44d804096f7022f833be
Thanks for your contribution!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2015-07-18 21:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-13 0:38 [Buildroot] [PATCH v2] quazip: new package Zoltan Gyarmati
2015-07-18 21:51 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150718235140.5a4eb571@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox