From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] busybox: linux-pam support requires threads
Date: Mon, 20 Jul 2015 16:03:11 +0300 [thread overview]
Message-ID: <20150720130311.GN13027@tarshish> (raw)
In-Reply-To: <20150720143832.15fad90b@free-electrons.com>
Hi Thomas,
On Mon, Jul 20, 2015 at 02:38:32PM +0200, Thomas Petazzoni wrote:
> On Mon, 20 Jul 2015 13:33:42 +0300, Baruch Siach wrote:
> > Commit 083aeac94e19 (busybox: added linux-pam support, 2015-07-14) enabled
> > CONFIG_PAM when the linux-pam package is selected. Busybox build system adds
> > -lpthread unconditionally when CONFIG_PAM is enabled, which leads to build
> > failure when the toolchain does not support pthreads. Enable CONFIG_PAM only
> > when the toolchain supports threads.
> >
> > Fixes:
> > http://autobuild.buildroot.net/results/8df/8df14bde19a41b78aa6422a1649a570914f747ee/
> > http://autobuild.buildroot.net/results/30d/30dd11b576b590de513031fce5e034353f2f5544/
> > http://autobuild.buildroot.net/results/de6/de628d84b0ed49be8f5d021c789357b2e66f2b02/
> >
> > Cc: Matt Weber <matthew.weber@rockwellcollins.com>
> > Signed-off-by: Baruch Siach <baruch@tkos.co.il>
>
> I was pretty sure I already fixed that one. And I indeed already fixed
> it. Except that after that I merged another patch adding again
> Linux-PAM support in Busybox. Big mistake on my side:
>
> 083aeac94e19cde6abd4b29cf29db589327d8c49 busybox: added linux-pam support
> b0b3dc5612a012dd29293bee0cd848aa1b7c0b7d busybox: selinux support
> cdcd83f31ded1dbf6d13d16b4aafdf594b964d94 package: fix fallout from checking kconfig config files
> 3ff5f63e48237cf569aaba6be35e179bf8556a19 package/busybox: check for config file
> 89d39fc7a392530be043bac541ade0bef746edb6 initscripts: new package
> b98dd2355780c732bf440042fb8faafe731efc94 busybox: improve support for telnetd
> e1baac68bcb9fb3cb3d2603d238a2ce8e7eb1125 busybox: Install udhcpc script only if enabled
> aa1362f220e733689fe4210b0bb2433f6d595e6b busybox: adjust configuration to add fancy options to the sleep applet
> 98e1848db11e707f96504ccf9cb2ed09e6787dd1 busybox: PAM support needs thread support
> f21b2558a097d07b53b6f20a47770468e9e4f7ed busybox: added linux-pam support
>
> f21b2558a097d07b53b6f20a47770468e9e4f7ed was merged first, I fixed the
> thread dependency in 98e1848db11e707f96504ccf9cb2ed09e6787dd1 but then
> later on, I merged again a linux-pam dependency addition, which didn't
> conflict because the piece of code was added at a different place.
>
> So really, the proper fix is to revert
> 083aeac94e19cde6abd4b29cf29db589327d8c49. Can you send a patch doing
> this revert?
Just did. Thanks for the analysis.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
prev parent reply other threads:[~2015-07-20 13:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-20 10:33 [Buildroot] [PATCH] busybox: linux-pam support requires threads Baruch Siach
2015-07-20 12:38 ` Thomas Petazzoni
2015-07-20 13:03 ` Baruch Siach [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150720130311.GN13027@tarshish \
--to=baruch@tkos.co.il \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox