Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCHv2] core/pkg-generic: host variants inherits target's override-srcdir
Date: Mon, 20 Jul 2015 15:31:09 +0200	[thread overview]
Message-ID: <20150720153109.2b1677bd@free-electrons.com> (raw)
In-Reply-To: <1437311728-31289-1-git-send-email-yann.morin.1998@free.fr>

Dear Yann E. MORIN,

On Sun, 19 Jul 2015 15:15:28 +0200, Yann E. MORIN wrote:
> When a package has both a target and a host variants, and there is an
> override-srcdir set for the target variant, the host variant should
> inherit the target's override-srcdir, unless explicitly set, like we do
> for all other target-variant properties.
> 
> However, do not override it if expressly set to empty (i.e. when the
> user wants to override only the target variant).
> 
> Also, as we do for the other variables, the target variant never
> inherits from the host variant.
> 
> Reported-by: Mike <mikez@OpenPlayer.org>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: Arnout Vandecappelle <arnout@mind.be>
> 
> ---
> Changes v1 -> v2:
>   - really do not override the host variant if expressly set to empty
>     (Arnout)
> ---
>  package/pkg-generic.mk | 4 ++++
>  1 file changed, 4 insertions(+)

Applied, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      parent reply	other threads:[~2015-07-20 13:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-19 13:15 [Buildroot] [PATCHv2] core/pkg-generic: host variants inherits target's override-srcdir Yann E. MORIN
2015-07-19 20:38 ` Arnout Vandecappelle
2015-07-20  8:48   ` Maxime Hadjinlian
2015-07-20  9:08     ` Baruch Siach
2015-07-20  9:11       ` Maxime Hadjinlian
2015-07-20 13:31 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150720153109.2b1677bd@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox