Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [autobuild.buildroot.net] Build results for 2015-07-19
Date: Mon, 20 Jul 2015 22:38:51 +0200	[thread overview]
Message-ID: <20150720223851.68e8f706@free-electrons.com> (raw)
In-Reply-To: <1437422115.1945.4.camel@embedded.rocks>

Dear J?rg Krause,

On Mon, 20 Jul 2015 21:55:15 +0200, J?rg Krause wrote:

> >          arm |                 libtirpc-0.3.1 | NOK | 
> > http://autobuild.buildroot.net/results/80321de8d4c6c0a00439b07289a581
> > 8962128b43/
> 
> This is odd:
> # BR2_TOOLCHAIN_EXTERNAL_HAS_THREADS is not set
> # libtirpc needs a toolchain w/ threads
> 
> -> why is libtirpc build anyhow?

Take the configuration, run menuconfig and exit, you will see:

warning: (BR2_PACKAGE_NFS_UTILS) selects BR2_PACKAGE_RPCBIND which has unmet direct dependencies (BR2_TOOLCHAIN_HAS_THREADS && !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R2 && BR2_USE_MMU)

The problem is that nfs-utils selects libtirpc without properly caring
for the thread dependency. This is caused by a patch from Maxime
Hadjinlian that added a "select BR2_PACKAGE_RPCBIND" in
nfs-utils/Config.in.

Since we probably don't care much about using nfs-utils in a
non-threaded scenario, maybe we could simply do:

comment "nfs-utils needs a toolchain w/ threads"
        depends on BR2_USE_MMU
        depends on !BR2_TOOLCHAIN_HAS_THREADS

config BR2_PACKAGE_NFS_UTILS
        bool "nfs-utils"
        depends on BR2_TOOLCHAIN_HAS_THREADS # libtirpc, rpcbind
        select BR2_PACKAGE_LIBTIRPC if !BR2_TOOLCHAIN_HAS_NATIVE_RPC
        select BR2_PACKAGE_RPCBIND # runtime

We could try to be smarter and use portmap when no threads are
available, but really this is too much complexity for such a corner
case.

Care to send a patch?

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2015-07-20 20:38 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-20  6:30 [Buildroot] [autobuild.buildroot.net] Build results for 2015-07-19 Thomas Petazzoni
2015-07-20 12:30 ` Brendan Heading
2015-07-20 12:39   ` Thomas Petazzoni
2015-07-20 12:44   ` Baruch Siach
2015-07-20 12:49     ` Brendan Heading
2015-07-20 13:10       ` Thomas Petazzoni
2015-07-20 13:54         ` Brendan Heading
2015-07-20 19:55 ` Jörg Krause
2015-07-20 20:38   ` Thomas Petazzoni [this message]
2015-07-20 20:48     ` Jörg Krause

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150720223851.68e8f706@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox