From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4 1/4] qt5: bump version to 5.5.0
Date: Tue, 21 Jul 2015 11:13:04 +0200 [thread overview]
Message-ID: <20150721111304.28196bd2@free-electrons.com> (raw)
In-Reply-To: <1437468691-364-2-git-send-email-corjon.j@ecagroup.com>
Dear Julien Corjon,
On Tue, 21 Jul 2015 10:51:28 +0200, Julien Corjon wrote:
> --- a/package/qt5/qt5base/qt5base.mk
> +++ b/package/qt5/qt5base/qt5base.mk
> @@ -123,12 +123,10 @@ QT5BASE_CONFIGURE_OPTS += -eglfs
> QT5BASE_DEPENDENCIES += libegl
> ifeq ($(BR2_PACKAGE_IMX_GPU_VIV),y)
> QT5BASE_EXTRA_CFLAGS = -DENABLE_MX6_WORKAROUND
So here we use this QT5BASE_EXTRA_CFLAGS mechanism.
> -QT5BASE_EGLFS_PLATFORM_HOOKS_SOURCES = \
> - $(@D)/mkspecs/devices/linux-imx6-g++/qeglfshooks_imx6.cpp
> endif
> ifeq ($(BR2_PACKAGE_RPI_USERLAND),y)
> -QT5BASE_EGLFS_PLATFORM_HOOKS_SOURCES = \
> - $(@D)/mkspecs/devices/linux-rasp-pi-g++/qeglfshooks_pi.cpp
> +QT5BASE_CONFIGURE_OPTS += -I$(STAGING_DIR)/usr/include/interface/vcos/pthreads
> +QT5BASE_CONFIGURE_OPTS += -I$(STAGING_DIR)/usr/include/interface/vmcs_host/linux
And here we pass -I directly to the configure script.
I'm wondering if there isn't some room for factorization here. Maybe
the -DENABLE_MX6_WORKAROUND could be passed as a configure option as
well:
$ ./configure --help
-D <string> ........ Add an explicit define to the preprocessor.
-I <string> ........ Add an explicit include path.
-L <string> ........ Add an explicit library path.
Or we could pass the -I for the RaspberryPi stuff in
QT5BASE_EXTRA_CFLAGS.
But oh well, we probably need to get this some autobuilder testing, and
see what happens.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-07-21 9:13 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-08 18:35 [Buildroot] [PATCH v2 1/3] qt5: bump version to 5.5.0 Julien Corjon
2015-07-08 18:35 ` [Buildroot] [PATCH v2 2/3] qt5base: reorder patches Julien Corjon
2015-07-08 18:35 ` [Buildroot] [PATCH v2 3/3] qt5quick1, qt5script, qt5webkit: tag as legacy compatibility Julien Corjon
2015-07-10 14:20 ` [Buildroot] [PATCH v3 1/5] qt5: bump version to 5.5.0 Julien Corjon
2015-07-10 14:20 ` [Buildroot] [PATCH v3 2/5] qt5base: reorder patches Julien Corjon
2015-07-10 14:20 ` [Buildroot] [PATCH v3 3/5] qt5quick1, qt5script, qt5webkit: tag as legacy compatibility Julien Corjon
2015-07-10 14:20 ` [Buildroot] [PATCH v3 4/5] qt5webengine: new package Julien Corjon
2015-07-19 13:02 ` Thomas Petazzoni
2015-07-20 9:17 ` Julien CORJON
2015-07-20 9:25 ` Thomas Petazzoni
2015-12-23 9:40 ` Gary Bisson
2015-12-23 9:49 ` Thomas Petazzoni
2015-12-23 10:15 ` Julien CORJON
2015-12-23 14:21 ` Gary Bisson
2015-12-23 15:04 ` Julien CORJON
2015-07-10 14:20 ` [Buildroot] [PATCH v3 5/5] qt/qt5webchannel: " Julien Corjon
2015-07-21 8:51 ` [Buildroot] [PATCH v4 0/4] qt5 bump to 5.5.0 Julien Corjon
2015-07-21 8:51 ` [Buildroot] [PATCH v4 1/4] qt5: bump version " Julien Corjon
2015-07-21 9:13 ` Thomas Petazzoni [this message]
2015-07-21 8:51 ` [Buildroot] [PATCH v4 2/4] qt/qt5base: reorder patches Julien Corjon
2015-07-21 8:51 ` [Buildroot] [PATCH v4 3/4] qt/qt5quick1, qt/qt5script, qt/qt5webkit: tag as legacy compatibility Julien Corjon
2015-07-21 8:51 ` [Buildroot] [PATCH v4 4/4] qt/qt5webchannel: new package Julien Corjon
2015-07-21 11:30 ` [Buildroot] [PATCH v5 0/4] qt5 bump to 5.5.0 Julien Corjon
2015-07-21 11:30 ` [Buildroot] [PATCH v5 1/4] qt5: bump version " Julien Corjon
2015-07-21 11:30 ` [Buildroot] [PATCH v5 2/4] qt/qt5base: reorder patches Julien Corjon
2015-07-21 11:30 ` [Buildroot] [PATCH v5 3/4] qt/qt5quick1, qt/qt5script, qt/qt5webkit: tag as legacy compatibility Julien Corjon
2015-07-21 11:30 ` [Buildroot] [PATCH v5 4/4] qt/qt5webchannel: new package Julien Corjon
2015-07-21 21:41 ` [Buildroot] [PATCH v5 0/4] qt5 bump to 5.5.0 Thomas Petazzoni
2015-07-19 21:22 ` [Buildroot] [PATCH v2 1/3] qt5: bump version " Thomas Petazzoni
2015-07-20 11:07 ` Julien CORJON
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150721111304.28196bd2@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox