Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] zedboard: Use default U-Boot after bump to 2015.07
Date: Wed, 22 Jul 2015 11:35:31 +0200	[thread overview]
Message-ID: <20150722113531.0e3345ab@free-electrons.com> (raw)
In-Reply-To: <20150722113054.1c0508f0@pcviktorin.fit.vutbr.cz>

Jan,

On Wed, 22 Jul 2015 11:30:54 +0200, Jan Viktorin wrote:

> diff --git a/configs/zedboard_defconfig b/configs/zedboard_defconfig
> index 99720db..5c3143a 100644
> --- a/configs/zedboard_defconfig
> +++ b/configs/zedboard_defconfig
> @@ -18,9 +18,6 @@ BR2_TARGET_ROOTFS_CPIO_GZIP=y
>  BR2_TARGET_ROOTFS_CPIO_UIMAGE=y
>  BR2_TARGET_UBOOT=y
>  BR2_TARGET_UBOOT_BOARDNAME="zynq_zed"
> -BR2_TARGET_UBOOT_CUSTOM_GIT=y
> -BR2_TARGET_UBOOT_CUSTOM_REPO_URL="git://git.denx.de/u-boot.git"
> -BR2_TARGET_UBOOT_CUSTOM_REPO_VERSION="v2015.07-rc2"
>  BR2_TARGET_UBOOT_PATCH="$(TOPDIR)/board/avnet/zedboard/uboot"
>  BR2_TARGET_UBOOT_FORMAT_DTB_IMG=y
>  BR2_TARGET_UBOOT_SPL=y

This is not good: we want defconfig to explicitly state which U-Boot
and kernel versions they use. Imagine that in 3 months time, the U-Boot
package gets updated to use 2015.11 by default, and that it doesn't
work on Zedboard: your defconfig is broken. Also your patch may no
longer apply.

While there is certainly some variation that will occur on the
compiler/C library version, we really would like to keep the U-Boot and
kernel versions explicit.

So instead of this change, can you change to point to the 2015.07
U-Boot tarball?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      reply	other threads:[~2015-07-22  9:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-22  9:30 [Buildroot] [PATCH] zedboard: Use default U-Boot after bump to 2015.07 Jan Viktorin
2015-07-22  9:35 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150722113531.0e3345ab@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox