From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 4/4 v8] package/linux-backports: switch to using the kernel-module infra
Date: Wed, 22 Jul 2015 17:05:39 +0200 [thread overview]
Message-ID: <20150722170539.580d5638@free-electrons.com> (raw)
In-Reply-To: <200f17ef13ac12610b33139a1b1f8820fc0c85bd.1437576751.git.yann.morin.1998@free.fr>
Dear Yann E. MORIN,
On Wed, 22 Jul 2015 16:58:55 +0200, Yann E. MORIN wrote:
> +LINUX_BACKPORTS_MAKE_OPTS = \
> + BACKPORT_DIR=$(@D) \
> + KLIB_BUILD=$(LINUX_DIR) \
> + KLIB=$(TARGET_DIR)/lib/modules/$(LINUX_VERSION_PROBED) \
> + `sed -r -e '/^\#/d;' $(@D)/.config`
For sure this last line needs a comment.
> +LINUX_BACKPORTS_MODULE_MAKE_OPTS = $(LINUX_BACKPORTS_MAKE_OPTS)
What is this useful for?
> +define LINUX_BACKPORTS_AUTOCONF
> + $(MAKE) -C $(@D) $(LINUX_BACKPORTS_MAKE_OPTS) backport-include/backport/autoconf.h
> +endef
> +LINUX_BACKPORTS_POST_CONFIGURE_HOOKS += LINUX_BACKPORTS_AUTOCONF
Also a comment above this would be good to have.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-07-22 15:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-22 14:58 [Buildroot] [PATCH 0/4 v8] linux-backports (new package) and misc related fixes (branch yem/linux-backports) Yann E. MORIN
2015-07-22 14:58 ` [Buildroot] [PATCH 1/4 v8] core/pkg-kconfig: do not override @D Yann E. MORIN
2015-07-22 14:58 ` [Buildroot] [PATCH 2/4 v8] package/linux: trash stderr in LINUX_VERSION_PROBED Yann E. MORIN
2015-07-22 14:58 ` [Buildroot] [PATCH 3/4 v8] package/linux-backports: new package Yann E. MORIN
2015-07-22 15:03 ` Thomas Petazzoni
2015-07-22 14:58 ` [Buildroot] [PATCH 4/4 v8] package/linux-backports: switch to using the kernel-module infra Yann E. MORIN
2015-07-22 15:05 ` Thomas Petazzoni [this message]
2015-07-22 15:25 ` [Buildroot] [PATCH 0/4 v8] linux-backports (new package) and misc related fixes (branch yem/linux-backports) Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150722170539.580d5638@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox