Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/1] e2fsprogs: remove busybox tune2fs when installing full version
Date: Wed, 22 Jul 2015 17:06:48 +0200	[thread overview]
Message-ID: <20150722170648.0a5183e8@free-electrons.com> (raw)
In-Reply-To: <1436392260-55786-1-git-send-email-ryan.barnett@rockwellcollins.com>

Dear Ryan Barnett,

On Wed,  8 Jul 2015 16:51:00 -0500, Ryan Barnett wrote:

> +# Remove busybox tune2fs and e2label since that will take precedence full version
>  define E2FSPROGS_TARGET_TUNE2FS_SYMLINK
> +	$(if $(BR2_PACKAGE_BUSYBOX), \
> +		rm -f $(TARGET_DIR)/sbin/tune2fs; \
> +		rm -f $(TARGET_DIR)/sbin/e2label;)
>  	ln -sf e2label $(TARGET_DIR)/usr/sbin/tune2fs
>  endef

I really didn't like the hijacking of E2FSPROGS_TARGET_TUNE2FS_SYMLINK
for the purposes of Busybox related issues, so I've separated the
Busybox related handling into a different post install target hook and
committed.

Please check
http://git.buildroot.net/buildroot/commit/?id=aa02829240b2927b2cb379eb904b6f40ff751237

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      parent reply	other threads:[~2015-07-22 15:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-08 21:51 [Buildroot] [PATCH v2 1/1] e2fsprogs: remove busybox tune2fs when installing full version Ryan Barnett
2015-07-09  3:14 ` Baruch Siach
2015-07-22 15:06 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150722170648.0a5183e8@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox