From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] Fix ncurses gcc-5.0 compile issue (for real)
Date: Thu, 23 Jul 2015 22:33:35 +0200 [thread overview]
Message-ID: <20150723223335.60374492@free-electrons.com> (raw)
In-Reply-To: <1437679186-15114-1-git-send-email-bas@bmail.ru>
Dear kyak,
On Thu, 23 Jul 2015 22:19:46 +0300, kyak wrote:
> The previous patch didn't work in all cases. The new patch is taken from
> upstream:
>
> http://ncurses.scripts.mit.edu/?p=ncurses.git;a=blobdiff;f=ncurses/base/MKlib_gen.sh;h=b91398c740a266f10edbbce19f19c52b9709556f;hp=d8cc3c9751faa157d0c8cb8e16fbe4217703966b;hb=97bb4678dc03e753290b39bbff30ba2825df9517;hpb=762520a7930d7f698d542628d3c04bc201f7dac2
> Signed-off-by: kyak <bas@bmail.ru>
We need a real name for Signed-off-by / Author. Can you fix this?
Also:
* There should be one empty line before the Signed-off-by line.
* The title should be "<package>: <description>", so: "ncurses: fix
gcc 5 compile issue for real" (saying 5.0 is incorrect since there
has never really been a gcc 5.0, the first stable release was 5.1).
* Can you include the upstream patch reference in the patch
description itself, and Signed-off-by the patch itself as well? See
http://buildroot.org/downloads/manual/manual.html#_format_and_licensing_of_the_package_patches
for more details.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-07-23 20:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-23 19:19 [Buildroot] [PATCH 1/1] Fix ncurses gcc-5.0 compile issue (for real) kyak
2015-07-23 19:27 ` Gustavo Zacarias
2015-07-23 20:33 ` Thomas Petazzoni [this message]
2015-07-24 10:04 ` Jaap Crezee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150723223335.60374492@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox