Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] ltp-testsuite: support building with toolchains without native RPC
Date: Sat, 25 Jul 2015 16:15:44 +0200	[thread overview]
Message-ID: <20150725141544.GF3662@free.fr> (raw)
In-Reply-To: <E2B4183D-A17C-4117-8FB4-879DC988B634@gmail.com>

Thomas, All,

On 2015-07-25 15:12 +0200, Thomas De Schampheleire spake thusly:
> On July 25, 2015 2:19:50 PM CEST, "Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> >On 2015-07-24 22:08 +0200, Thomas De Schampheleire spake thusly:
[--SNIP--]
> >> index 2d4f286..05ffaf1 100644
> >> --- a/package/ltp-testsuite/ltp-testsuite.mk
> >> +++ b/package/ltp-testsuite/ltp-testsuite.mk
> >> @@ -19,8 +19,18 @@ endif
> >>  
> >>  # ltp-testsuite uses <fts.h>, which isn't compatible with largefile
> >>  # support.
> >> +LTP_TESTSUITE_CFLAGS = $(filter-out
> >-D_FILE_OFFSET_BITS=64,$(TARGET_CFLAGS))
> >> +LTP_TESTSUITE_CPPFLAGS = $(filter-out
> >-D_FILE_OFFSET_BITS=64,$(TARGET_CPPFLAGS))
> >
> >This hunk does not seem to have anything to do with the issue at hand,
> >namely RPC and musl, nor is it explained in the commit log. Care to
> >explain why filtering it out is needed (in the commit log and a comment
> >in the code), please?
> 
> These lines were already in that file (see removes below); I left the comment clarifying it. 
> I just introduced intermediate variables to cleanly handle the tirpc changes.

Indeed, my bad.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2015-07-25 14:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-24 20:08 [Buildroot] [PATCH 1/1] ltp-testsuite: support building with toolchains without native RPC Thomas De Schampheleire
2015-07-25 12:19 ` Yann E. MORIN
2015-07-25 13:12   ` Thomas De Schampheleire
2015-07-25 14:15     ` Yann E. MORIN [this message]
2015-07-25 14:32 ` Yann E. MORIN
2015-07-25 19:44   ` Thomas De Schampheleire

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150725141544.GF3662@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox