From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Makefile: unexport O
Date: Sun, 26 Jul 2015 15:07:18 +0200 [thread overview]
Message-ID: <20150726150718.5ecc6679@free-electrons.com> (raw)
In-Reply-To: <1437851259-4539-1-git-send-email-guido@vanguardiasur.com.ar>
Dear Guido Mart?nez,
On Sat, 25 Jul 2015 16:07:39 -0300, Guido Mart?nez wrote:
> After bee5745ccc2 ("Makefile: don't depend on the umask"), any use
> of "make O=<dir>" would leak $O into the enviroment for submakes,
> and it's inherited by package makefiles. Some package makefiles have
> protections to make sure they don't use the value of $O if it comes from
> the enviroment (Linux), but some don't (uClibc).
>
> This caused build failures when using a different output dir.
>
> Fix this by unconditionally unexporting the O variable, since we never
> need to have it set in the environment for packages, it should be only
> internally used by BR.
>
> Signed-off-by: Guido Mart?nez <guido@vanguardiasur.com.ar>
> ---
> Makefile | 1 +
> 1 file changed, 1 insertion(+)
Applied, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2015-07-26 13:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-25 19:07 [Buildroot] [PATCH] Makefile: unexport O Guido Martínez
2015-07-25 19:34 ` Yann E. MORIN
2015-07-25 21:48 ` Romain Naour
2015-07-26 13:07 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150726150718.5ecc6679@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox