From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Sun, 26 Jul 2015 15:10:05 +0200 Subject: [Buildroot] [PATCH] package/exim: Fix compilation error with musl In-Reply-To: <1437831415-6066-1-git-send-email-luca@lucaceresoli.net> References: <1437831415-6066-1-git-send-email-luca@lucaceresoli.net> Message-ID: <20150726151005.12a9989d@free-electrons.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Dear Luca Ceresoli, On Sat, 25 Jul 2015 15:36:55 +0200, Luca Ceresoli wrote: > From: Bernd Kuhls > > Fixes > smtp_in.c: In function ?smtp_start_session?: > smtp_in.c:1976:36: error: invalid application of ?sizeof? to incomplete type ?struct options? > EXIM_SOCKLEN_T optlen = sizeof(struct ip_options) + MAX_IPOPTLEN; > > smtp_in.c misdetects the needed style for ip_options, only OPTSTYLE == 2 works. > Since musl does not provide any macro[1] to detect it we need to pretend to be > darwin in order to fix the compile bug. > > [1] http://wiki.musl-libc.org/wiki/FAQ#Q:_why_is_there_no_MUSL_macro_.3F > > Signed-off-by: Bernd Kuhls > [Luca: simplify by using only one sed invocation] > Signed-off-by: Luca Ceresoli > > --- > > I'm adopting this oldish patch (https://patchwork.ozlabs.org/patch/460496/) > from Bernd. The bug it fixes is still there, and the fix is still valid. I > just simplified it according to my comments to the original patch. Thanks for picking up an old patch, definitely useful! I'm not too happy with us pretending to be Darwin when building against Musl, as it could fire back on us in the future (like if Exim starts using something really Darwin specific). But oh well, I guess it's good enough for now. Thanks! Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com