Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v8 1/1] mosh: new package
Date: Sun, 26 Jul 2015 21:41:30 +0200	[thread overview]
Message-ID: <20150726214130.196b8cbf@free-electrons.com> (raw)
In-Reply-To: <CA+h8R2qyYPpyNpASpjg1+8ivxhX2x8yvD4pdzhSn3W=ypphqQg@mail.gmail.com>

Dear Christian Stewart,

Please don't top-post, thanks!

On Sun, 26 Jul 2015 18:02:29 +0000, Christian Stewart wrote:

> No, they will reject it regardless of how it is coded. Checking a global
> POSIX command exists is not worth it to them as it exists on most systems
> anyway. They requested I make a patch for BR that outputs a special debug
> line for buildroot users so they know what they're dealing with if someone
> submits a log.

Can you try anyway? Because what I'm proposing is significantly
different from what you proposed in your pull request. My proposal has
the advantage of keeping the locale output when 'locale' is available
*and* warn that locale is not available otherwise. Basically it exactly
matches the requirements of the upstream mosh developers.

We don't like to keep patches in Buildroot forever, so having an
upstreamable solution is important.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2015-07-26 19:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-26 16:34 [Buildroot] [PATCH v8 1/1] mosh: new package Christian Stewart
2015-07-26 17:01 ` Yann E. MORIN
2015-07-26 17:35 ` Thomas Petazzoni
2015-07-26 18:02   ` Christian Stewart
2015-07-26 19:41     ` Thomas Petazzoni [this message]
2015-07-27 21:38       ` Christian Stewart
2015-07-26 22:20 ` Baruch Siach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150726214130.196b8cbf@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox