From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCHv2 1/1] xterm: x-includes and x-libraries must be set for cross-compiling
Date: Sun, 26 Jul 2015 21:47:00 +0200 [thread overview]
Message-ID: <20150726214700.68302c4a@free-electrons.com> (raw)
In-Reply-To: <1437932796-16216-1-git-send-email-bas@bmail.ru>
Hello,
On Sun, 26 Jul 2015 20:46:36 +0300, kyak wrote:
> From: Mikhail Peselnik <bas@bmail.ru>
>
> These flags need to be set so that the configure script would
> correctly use libICE from cross-toolchain rather than from host.
> Also, the xterm package is missing the freetype2 dependency, as
> noted by Romain Naour.
So it should be two patches.
Basically, if your patch does something that isn't summarized in the
commit title, then probably something wrong is going on.
So, one patch for x-includes/x-libraries, one patch for the missing
freetype2 dependency.
However, I believe Romain was maybe wrong: the freetype dependency
seems to be optional, according to configure.in. So it should probably
just be:
ifeq ($(BR2_PACKAGE_FREETYPE),y)
XTERM_DEPENDENCIES += freetype
XTERM_CONF_OPTS += --enable-freetype
else
XTERM_CONF_OPTS += --disable-freetype
endif
Romain, can you confirm?
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-07-26 19:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-26 17:46 [Buildroot] [PATCHv2 1/1] xterm: x-includes and x-libraries must be set for cross-compiling kyak
2015-07-26 17:59 ` Yann E. MORIN
2015-07-26 19:37 ` Romain Naour
2015-07-26 19:44 ` Thomas Petazzoni
2015-07-26 20:02 ` Yann E. MORIN
2015-07-26 19:47 ` Thomas Petazzoni [this message]
2015-07-26 21:03 ` Romain Naour
2015-07-26 21:25 ` Thomas Petazzoni
2015-07-27 14:49 ` Romain Naour
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150726214700.68302c4a@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox